Disable all informing jobs on 4.20 release controllers#78000
Disable all informing jobs on 4.20 release controllers#78000openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThree release controller configuration files updated to disable verification jobs by adding Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-merge-bot
Bot
added
the
rehearsals-ack
All optional (informing) jobs are disabled across the 4.20 nightly, multi, and OKD SCOS release controllers. The install-analysis-all and overall-analysis-all blocking jobs are also disabled since they aggregate data from informing jobs that will no longer run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
sdodson
force-pushed
the
disable-4.20-informing-jobs
branch
from
e0cdaa6 to
9431d7d
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (4)
core-services/release-controller/_repos/ocp-5.0-rhel9.repo (2)
24-24: Minor: Spacing inconsistency with 4.22 file.This file uses
excludepkgs = toolbox*(with spaces) while ocp-4.22-rhel9.repo usesexcludepkgs=toolbox*(no spaces). Consider aligning the style across both files.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core-services/release-controller/_repos/ocp-5.0-rhel9.repo` at line 24, The line with the package exclusion currently uses spaced syntax "excludepkgs = toolbox*"; update it to match the style used in the other repo file by removing spaces so it reads "excludepkgs=toolbox*" (locate the occurrence of excludepkgs in ocp-5.0-rhel9.repo and replace the spaced form with the compact form to ensure consistent formatting across files).
104-108: Minor: Trailing comma and extra blank line.Line 107 has a trailing comma and line 108 introduces an extra blank line before the next section.
🔧 Suggested fix
# https://issues.redhat.com/browse/OCPBUGS-56600 -includepkgs = kernel,kernel-*,toolbox*, - +includepkgs = kernel,kernel-*,toolbox*🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core-services/release-controller/_repos/ocp-5.0-rhel9.repo` around lines 104 - 108, Remove the trailing comma from the includepkgs line and delete the extra blank line after it so the line reads without a trailing comma (replace "includepkgs = kernel,kernel-*,toolbox*," with "includepkgs = kernel,kernel-*,toolbox*") and ensure no empty line follows before the next section; locate the offending line by searching for the exact string "includepkgs = kernel,kernel-*,toolbox*," in the repo file.core-services/release-controller/_repos/ocp-4.22-rhel9.repo (2)
62-63: Inconsistent section naming:rhel-98-vsrhel-9.8-.The codeready-builder section uses
rhel-98-(without dot) while other sections userhel-9.8-(with dot). If this is intentional to distinguish CDN-based repos, consider adding a comment. Otherwise, align withrhel-9.8-codeready-builder-rpmsfor consistency.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core-services/release-controller/_repos/ocp-4.22-rhel9.repo` around lines 62 - 63, The repo section name "[rhel-98-codeready-builder-rpms]" is inconsistent with other sections that use "rhel-9.8-" (with a dot); either rename the section to "[rhel-9.8-codeready-builder-rpms]" to match the existing convention or, if the "rhel-98-" form is intentional for CDN-based repos, add a clear inline comment above the "[rhel-98-codeready-builder-rpms]" section explaining why it differs; update any references to this section name elsewhere (search for "rhel-98-codeready-builder-rpms") to keep them in sync.
107-107: Minor: Trailing comma inincludepkgsvalue.The trailing comma after
toolbox*is unnecessary and inconsistent with theexcludepkgsdirective on line 24.🔧 Suggested fix
-includepkgs=kernel,kernel-*,toolbox*, +includepkgs=kernel,kernel-*,toolbox*🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core-services/release-controller/_repos/ocp-4.22-rhel9.repo` at line 107, The includepkgs directive currently ends with an unnecessary trailing comma ("includepkgs=kernel,kernel-*,toolbox*,"); remove the trailing comma so the value becomes a comma-separated list without a trailing delimiter (i.e., "includepkgs=kernel,kernel-*,toolbox*") to match the style used by excludepkgs and avoid parsing inconsistencies.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@core-services/release-controller/_repos/ocp-4.22-rhel9.repo`:
- Around line 62-63: The repo section name "[rhel-98-codeready-builder-rpms]" is
inconsistent with other sections that use "rhel-9.8-" (with a dot); either
rename the section to "[rhel-9.8-codeready-builder-rpms]" to match the existing
convention or, if the "rhel-98-" form is intentional for CDN-based repos, add a
clear inline comment above the "[rhel-98-codeready-builder-rpms]" section
explaining why it differs; update any references to this section name elsewhere
(search for "rhel-98-codeready-builder-rpms") to keep them in sync.
- Line 107: The includepkgs directive currently ends with an unnecessary
trailing comma ("includepkgs=kernel,kernel-*,toolbox*,"); remove the trailing
comma so the value becomes a comma-separated list without a trailing delimiter
(i.e., "includepkgs=kernel,kernel-*,toolbox*") to match the style used by
excludepkgs and avoid parsing inconsistencies.
In `@core-services/release-controller/_repos/ocp-5.0-rhel9.repo`:
- Line 24: The line with the package exclusion currently uses spaced syntax
"excludepkgs = toolbox*"; update it to match the style used in the other repo
file by removing spaces so it reads "excludepkgs=toolbox*" (locate the
occurrence of excludepkgs in ocp-5.0-rhel9.repo and replace the spaced form with
the compact form to ensure consistent formatting across files).
- Around line 104-108: Remove the trailing comma from the includepkgs line and
delete the extra blank line after it so the line reads without a trailing comma
(replace "includepkgs = kernel,kernel-*,toolbox*," with "includepkgs =
kernel,kernel-*,toolbox*") and ensure no empty line follows before the next
section; locate the offending line by searching for the exact string
"includepkgs = kernel,kernel-*,toolbox*," in the repo file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 10429a58-e863-441b-af8a-c30552f0f72f
📒 Files selected for processing (5)
core-services/release-controller/_releases/release-ocp-4.20-multi.jsoncore-services/release-controller/_releases/release-ocp-4.20.jsoncore-services/release-controller/_releases/release-okd-scos-4.20.jsoncore-services/release-controller/_repos/ocp-4.22-rhel9.repocore-services/release-controller/_repos/ocp-5.0-rhel9.repo
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jupierce, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@sdodson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
"disabled": trueinstall-analysis-allandoverall-analysis-allblocking analysis jobs on the nightly controller, since they aggregate results from informing jobs that will no longer run (consistent with the 4.17 and 4.18 pattern)upgrade-minor-aws-ovn) was already disabled — no change neededAffected files
core-services/release-controller/_releases/release-ocp-4.20.jsoncore-services/release-controller/_releases/release-ocp-4.20-multi.jsoncore-services/release-controller/_releases/release-okd-scos-4.20.jsonTest plan
make release-controllerssucceeds"disabled": trueinstall-analysis-allandoverall-analysis-allare disabled🤖 Generated with Claude Code
Summary by CodeRabbit