prow config: allow petr-muller to rerun jobs#78011
prow config: allow petr-muller to rerun jobs#78011openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
I do a lot around OpenShift CI, occassionaly I need to rerun a job for one reason or another, and I never learned how to use Gangway.
WalkthroughA single GitHub user ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
core-services/prow/02_config/_config.yaml (1)
19-26: Consider alphabetical ordering for maintainability.The
github_userslist is not alphabetically sorted. While the current approach (appending to the end) is consistent with the existing pattern, alphabetical ordering would improve readability and make it easier to spot duplicates or locate specific users in the future.📝 Alphabetically sorted list
github_users: - - deads2k - - vikaslaad - - dobbymoodge - - bparees - AlexNPavel + - bparees + - deads2k + - dobbymoodge - jupierce - petr-muller + - vikaslaad🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core-services/prow/02_config/_config.yaml` around lines 19 - 26, The github_users list under the github_users key is not alphabetically ordered; sort the entries in that list (github_users) into ascending alphabetical order (case-insensitive) so items like AlexNPavel, bparees, deads2k, dobbymoodge, jupierce, petr-muller, vikaslaad appear in proper order; update the yaml sequence for the github_users key accordingly while preserving indentation and existing entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@core-services/prow/02_config/_config.yaml`:
- Around line 19-26: The github_users list under the github_users key is not
alphabetically ordered; sort the entries in that list (github_users) into
ascending alphabetical order (case-insensitive) so items like AlexNPavel,
bparees, deads2k, dobbymoodge, jupierce, petr-muller, vikaslaad appear in proper
order; update the yaml sequence for the github_users key accordingly while
preserving indentation and existing entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1605672b-4213-4b52-9e11-d4a4856e8b7b
📒 Files selected for processing (1)
core-services/prow/02_config/_config.yaml
|
@petr-muller: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label ready-for-human-review |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hector-vido, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@petr-muller: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I do a lot around OpenShift CI, occassionaly I need to rerun a job for one reason or another, and I never learned how to use Gangway.
I do a lot around OpenShift CI, occassionaly I need to rerun a job for one reason or another, and I never learned how to use Gangway.
I do a lot around OpenShift CI, occassionaly I need to rerun a job for one reason or another, and I never learned how to use Gangway.
I do a lot around OpenShift CI, occassionaly I need to rerun a job for one reason or another, and I never learned how to use Gangway.
/cc @jmguzik
Summary by CodeRabbit