Skip to content

prow config: allow petr-muller to rerun jobs#78011

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
petr-muller:i-want-to-rerun-jobs
Apr 23, 2026
Merged

prow config: allow petr-muller to rerun jobs#78011
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
petr-muller:i-want-to-rerun-jobs

Conversation

@petr-muller
Copy link
Copy Markdown
Member

@petr-muller petr-muller commented Apr 19, 2026

I do a lot around OpenShift CI, occassionaly I need to rerun a job for one reason or another, and I never learned how to use Gangway.

/cc @jmguzik

Summary by CodeRabbit

  • Chores
    • Extended authorization configuration to allow additional user permissions for job reruns in the deployment pipeline.

I do a lot around OpenShift CI, occassionaly I need to rerun a job for
one reason or another, and I never learned how to use Gangway.
@openshift-ci openshift-ci Bot requested a review from jmguzik April 19, 2026 19:02
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 19, 2026

Walkthrough

A single GitHub user (petr-muller) was added to the rerun authorization configuration in the Prow deck's default configuration file for all repositories.

Changes

Cohort / File(s) Summary
Configuration
core-services/prow/02_config/_config.yaml
Added petr-muller to the rerun_auth_configs.github_users list under deck.default_rerun_auth_configs for repo: '*'.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 9 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Microshift Test Compatibility ❓ Inconclusive Unable to execute git commands to verify file changes and configuration. Git commands require access to a repository context which is not available in this environment.
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: adding petr-muller to the prow rerun authorization configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed This PR modifies only YAML configuration for Prow CI/CD settings and contains no Ginkgo test code or dynamic test names to evaluate.
Test Structure And Quality ✅ Passed PR modifies only YAML configuration file for Prow job rerun authorization, with no Ginkgo test code changes, making this check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR only modifies a Prow configuration file to grant job rerun permissions and does not add any new Ginkgo e2e tests or test code.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies Prow CI/CD config to add user to authorization list; unrelated to cluster topology scheduling.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check is not applicable to this PR which only modifies a YAML configuration file without introducing any code or test implementations.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies Prow configuration YAML to authorize user petr-muller; no new Ginkgo e2e tests are introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 19, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@petr-muller: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
core-services/prow/02_config/_config.yaml (1)

19-26: Consider alphabetical ordering for maintainability.

The github_users list is not alphabetically sorted. While the current approach (appending to the end) is consistent with the existing pattern, alphabetical ordering would improve readability and make it easier to spot duplicates or locate specific users in the future.

📝 Alphabetically sorted list
       github_users:
-      - deads2k
-      - vikaslaad
-      - dobbymoodge
-      - bparees
       - AlexNPavel
+      - bparees
+      - deads2k
+      - dobbymoodge
       - jupierce
       - petr-muller
+      - vikaslaad
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@core-services/prow/02_config/_config.yaml` around lines 19 - 26, The
github_users list under the github_users key is not alphabetically ordered; sort
the entries in that list (github_users) into ascending alphabetical order
(case-insensitive) so items like AlexNPavel, bparees, deads2k, dobbymoodge,
jupierce, petr-muller, vikaslaad appear in proper order; update the yaml
sequence for the github_users key accordingly while preserving indentation and
existing entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@core-services/prow/02_config/_config.yaml`:
- Around line 19-26: The github_users list under the github_users key is not
alphabetically ordered; sort the entries in that list (github_users) into
ascending alphabetical order (case-insensitive) so items like AlexNPavel,
bparees, deads2k, dobbymoodge, jupierce, petr-muller, vikaslaad appear in proper
order; update the yaml sequence for the github_users key accordingly while
preserving indentation and existing entries.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1605672b-4213-4b52-9e11-d4a4856e8b7b

📥 Commits

Reviewing files that changed from the base of the PR and between ed9431c and 9dd4a30.

📒 Files selected for processing (1)
  • core-services/prow/02_config/_config.yaml

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 19, 2026

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@petr-muller
Copy link
Copy Markdown
Member Author

/label ready-for-human-review

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Apr 23, 2026
@hector-vido
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hector-vido, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit a2fc076 into openshift:main Apr 23, 2026
12 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 23, 2026

@petr-muller: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
Details

In response to this:

I do a lot around OpenShift CI, occassionaly I need to rerun a job for one reason or another, and I never learned how to use Gangway.

/cc @jmguzik

Summary by CodeRabbit

  • Chores
  • Extended authorization configuration to allow additional user permissions for job reruns in the deployment pipeline.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tbuskey pushed a commit to tbuskey/release that referenced this pull request Apr 24, 2026
I do a lot around OpenShift CI, occassionaly I need to rerun a job for
one reason or another, and I never learned how to use Gangway.
Prucek pushed a commit to Prucek/release that referenced this pull request Apr 29, 2026
I do a lot around OpenShift CI, occassionaly I need to rerun a job for
one reason or another, and I never learned how to use Gangway.
BATMAN-JD pushed a commit to BATMAN-JD/release that referenced this pull request May 1, 2026
I do a lot around OpenShift CI, occassionaly I need to rerun a job for
one reason or another, and I never learned how to use Gangway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants