osc: add tide configs to trigger merge automation#78012
osc: add tide configs to trigger merge automation#78012thejasn wants to merge 1 commit intoopenshift:mainfrom
Conversation
Add missing plugins and tide config to enable ease of merge Signed-off-by: Thejas N <thn@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thejasn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughThis PR adds Prow plugin and merge configurations for the openshift/sandboxed-containers-operator repository, enabling self-approval and configuring automated merge behavior with specific label requirements. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@core-services/prow/02_config/openshift/sandboxed-containers-operator/_pluginconfig.yaml`:
- Around line 7-10: The repository entry
"openshift/sandboxed-containers-operator" incorrectly nests a "plugins:" key;
remove that nested key and place the flat list of plugin names directly under
the repository key so the "approve" plugin is defined as a top-level list item
for openshift/sandboxed-containers-operator. Update the block that references
"openshift/sandboxed-containers-operator" to have a single plugins list
containing "approve" (no inner "plugins:" object), ensuring it conforms to
Prow's sigs.k8s.io/prow/pkg/plugins schema.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 95a08bd2-afd7-4a26-be88-955906a29cfe
📒 Files selected for processing (2)
core-services/prow/02_config/openshift/sandboxed-containers-operator/_pluginconfig.yamlcore-services/prow/02_config/openshift/sandboxed-containers-operator/_prowconfig.yaml
| plugins: | ||
| openshift/sandboxed-containers-operator: | ||
| plugins: | ||
| - approve |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify plugin map structure used across repository plugin configs.
# Expected pattern examples: plugins: <repo>: - approve
set -euo pipefail
echo "== Files containing nested repo.plugins key under pluginconfig =="
rg -n -C2 '^(\s{2,}|\t+)plugins:\s*$' $(fd '_pluginconfig\.yaml$')
echo
echo "== Files containing direct repo -> list form in pluginconfig =="
rg -n -C2 '^plugins:\n(\s{2,}|\t+)[^:\n]+/[^:\n]+:\n(\s{2,}|\t+)-\s+\w+' $(fd '_pluginconfig\.yaml$') || trueRepository: openshift/release
Length of output: 50583
🏁 Script executed:
# Look at the specific file being reviewed to confirm its exact structure
cat core-services/prow/02_config/openshift/sandboxed-containers-operator/_pluginconfig.yamlRepository: openshift/release
Length of output: 309
🌐 Web query:
Prow plugin configuration schema nested plugins structure YAML format
💡 Result:
The Prow plugin configuration is defined in a YAML file named plugins.yaml. This file specifies which plugins are enabled for specific organizations and repositories, along with plugin-specific configurations. There is no formal JSON schema available in the official documentation, but the structure is defined by the Go struct in sigs.k8s.io/prow/pkg/plugins.Configuration, which can be viewed in Go documentation or source code. Key structure elements from official sources: - Top-level keys are plugin names (e.g., triggers, lgtm, size, config_updater, external_plugins). - Plugins are enabled per org or org/repo with lists of plugin names. - Plugin-specific configs are nested maps under each plugin name. Example from kubernetes/test-infra config/prow/plugins.yaml (master branch): plugins: kubernetes-sigs: - assign - trigger - label - mergecommitblocker - size - skip - wip triggers: - repos: - kubernetes-sigs/cluster-api # ... more repos join_org_url: "https://git.k8s.io/community/community-membership.md#member" only_org_members: true lgtm: - repos: - bazelbuild - kubernetes-sigs/aws-ebs-csi-driver # ... more repos review_acts_as_lgtm: true size: s: 10 m: 30 l: 100 xl: 500 config_updater: maps: config/prow/plugins.yaml: name: plugin external_plugins: org-foo/repo-bar: - name: refresh-remote endpoint: https://my-refresh-plugin.com events: - issue_comment The configuration is loaded and validated by Prow's ConfigAgent.Load function, which unmarshals YAML into the Configuration struct and checks for unknown plugins if enabled. For full field descriptions, refer to the GoDoc at https://godoc.org/sigs.k8s.io/prow/pkg/plugins or pkg.go.dev. Nested structure refers to: 1. Hierarchical enabling: org-level plugins apply to all repos unless excluded via excluded_repos; repo-specific overrides. 2. Plugin configs as nested objects (e.g., triggers.repos list, lgtm.review_acts_as_lgtm bool). 3. External plugins as nested lists under external_plugins. No evidence of deeply recursive "nested plugins" (plugins containing plugins); structure is flat lists with nested config objects per plugin type.
Citations:
- 1: https://github.com/kubernetes/test-infra/blob/master/config/prow/plugins.yaml
- 2: https://docs.prow.k8s.io/docs/components/plugins/
- 3: https://github.com/kubernetes-sigs/prow/blob/main/pkg/plugins/plugins.go
- 4: https://docs.prow.k8s.io/docs/components/plugins
- 5: https://godoc.org/sigs.k8s.io/prow/pkg/plugins
Remove nested plugins: key to match Prow's plugin configuration schema.
The nested plugins: at line 9 is invalid. According to Prow's official plugin configuration schema (from sigs.k8s.io/prow/pkg/plugins), repository-scoped plugins must be a flat list directly under the repository key, not a nested object. The current structure will prevent the approve plugin from loading.
Proposed fix
plugins:
openshift/sandboxed-containers-operator:
- plugins:
- - approve
+ - approve📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| plugins: | |
| openshift/sandboxed-containers-operator: | |
| plugins: | |
| - approve | |
| plugins: | |
| openshift/sandboxed-containers-operator: | |
| - approve |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@core-services/prow/02_config/openshift/sandboxed-containers-operator/_pluginconfig.yaml`
around lines 7 - 10, The repository entry
"openshift/sandboxed-containers-operator" incorrectly nests a "plugins:" key;
remove that nested key and place the flat list of plugin names directly under
the repository key so the "approve" plugin is defined as a top-level list item
for openshift/sandboxed-containers-operator. Update the block that references
"openshift/sandboxed-containers-operator" to have a single plugins list
containing "approve" (no inner "plugins:" object), ensuring it conforms to
Prow's sigs.k8s.io/prow/pkg/plugins schema.
|
@thejasn: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Add missing plugins and tide config to enable ease of merge..
This ensures all PR merges have a multi step approval process before merging. (as documented here)
Summary by CodeRabbit