Skip to content

fleetshift repos: change to image_stream_tag #78066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Apr 20, 2026
Merged

fleetshift repos: change to image_stream_tag #78066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
build_root:
from_repository: true
image_stream_tag:
name: builder
namespace: stolostron
tag: go1.25-linux
Comment on lines +2 to +5
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Confirm go1.25-linux is already referenced elsewhere as a known stolostron builder tag.
rg -nP --type=yaml -B2 -A2 'namespace:\s*stolostron' | rg -nP -B3 -A1 'tag:\s*go1\.'
# Full set of go builder tags in use across the repo for comparison.
rg -nP --type=yaml 'tag:\s*go1\.[0-9]+' | sort -u

Repository: openshift/release

Length of output: 50375

🏁 Script executed:

fd 'go.mod' -path '*fleetshift*' | head -20

Repository: openshift/release

Length of output: 229

🏁 Script executed:

fd 'go.mod' | grep -i fleetshift

Repository: openshift/release

Length of output: 43

The go1.25-linux tag is already published and widely used across the repo.

Concern #1 is resolved: The go1.25-linux tag exists in the stolostron/builder image stream and is already in active use by multiple projects (ocm, assisted-baremetal, volsync-addon-controller, thanos, must-gather, siteconfig, and others), so build-root resolution will succeed.

Concern #2 still requires verification: Whether Go 1.25 matches fleetshift-poc's go.mod toolchain directive must be checked in the actual fleetshift-poc repository, not in openshift/release. Confirm this before merging to avoid subtle build failures.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main.yaml`
around lines 2 - 5, The image_stream_tag uses tag "go1.25-linux" which is
published, but you must verify the fleetshift-poc repository's go.mod toolchain
directive matches Go 1.25; open the fleetshift-poc repo, inspect the go.mod "go"
(or "toolchain" if present) directive and if it specifies a different Go
version, either update this image_stream_tag tag to the correct builder image
(e.g., goX.Y-linux) or align the repo's go.mod/toolchain to 1.25; ensure you
modify the image_stream_tag block (name: builder, tag: go1.25-linux) or the
repo's go.mod accordingly before merging.

images:
items:
- dockerfile_path: Dockerfile
Expand Down
5 changes: 4 additions & 1 deletion ...onfig/fleetshift/fleetshift-user-interface/fleetshift-fleetshift-user-interface-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
build_root:
from_repository: true
image_stream_tag:
name: builder
namespace: stolostron
tag: nodejs20-linux
images:
items:
- dockerfile_path: Dockerfile.gui
Expand Down
2 changes: 2 additions & 0 deletions ci-operator/jobs/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main-postsubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ postsubmits:
- ^main$
cluster: build05
decorate: true
decoration_config:
skip_cloning: true
labels:
ci.openshift.io/generator: prowgen
max_concurrency: 1
Expand Down
4 changes: 4 additions & 0 deletions ci-operator/jobs/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ presubmits:
cluster: build08
context: ci/prow/images
decorate: true
decoration_config:
skip_cloning: true
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
Expand Down Expand Up @@ -61,6 +63,8 @@ presubmits:
cluster: build08
context: ci/prow/pr-image-mirror
decorate: true
decoration_config:
skip_cloning: true
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
Expand Down
6 changes: 6 additions & 0 deletions ...hift/fleetshift-user-interface/fleetshift-fleetshift-user-interface-main-postsubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ postsubmits:
- ^main$
cluster: build01
decorate: true
decoration_config:
skip_cloning: true
labels:
ci.openshift.io/generator: prowgen
max_concurrency: 1
Expand Down Expand Up @@ -73,6 +75,8 @@ postsubmits:
- ^main$
cluster: build01
decorate: true
decoration_config:
skip_cloning: true
labels:
ci.openshift.io/generator: prowgen
max_concurrency: 1
Expand Down Expand Up @@ -140,6 +144,8 @@ postsubmits:
- ^main$
cluster: build01
decorate: true
decoration_config:
skip_cloning: true
labels:
ci.openshift.io/generator: prowgen
max_concurrency: 1
Expand Down
8 changes: 8 additions & 0 deletions ...shift/fleetshift-user-interface/fleetshift-fleetshift-user-interface-main-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ presubmits:
cluster: build01
context: ci/prow/images
decorate: true
decoration_config:
skip_cloning: true
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
Expand Down Expand Up @@ -61,6 +63,8 @@ presubmits:
cluster: build01
context: ci/prow/pr-image-mirror-gui
decorate: true
decoration_config:
skip_cloning: true
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
Expand Down Expand Up @@ -132,6 +136,8 @@ presubmits:
cluster: build01
context: ci/prow/pr-image-mirror-mock-servers
decorate: true
decoration_config:
skip_cloning: true
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
Expand Down Expand Up @@ -203,6 +209,8 @@ presubmits:
cluster: build01
context: ci/prow/pr-image-mirror-mock-ui-plugins
decorate: true
decoration_config:
skip_cloning: true
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
Expand Down