Skip to content

Add KMM DRA e2e test to CI config#81479

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
TomerNewman:add-kmm-e2e-dra-test
Jul 8, 2026
Merged

Add KMM DRA e2e test to CI config#81479
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
TomerNewman:add-kmm-e2e-dra-test

Conversation

@TomerNewman

@TomerNewman TomerNewman commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Add an e2e-dra test that validates the full DRA lifecycle on an OCP 4.21 cluster (Kubernetes 1.34+ required for DRA).


/cc @ybettan @yevgeny-shnaidman
/assign @yevgeny-shnaidman @ybettan

Summary by CodeRabbit

This update extends the OpenShift CI Prow configuration for the rh-ecosystem-edge/kernel-module-management component by adding a new e2e-dra end-to-end test job to validate the KMM DRA lifecycle on an AWS-backed OCP 4.21 cluster claim.

In practical terms, the new e2e-dra job:

  • Provisions an AWS generic-claim for OCP version: "4.21" on amd64
  • Creates the openshift-kmm namespace
  • Installs the openshift-kmm operator via operator-sdk run bundle for the configured $OO_BUNDLE (including bundle dependency wiring from the operator-sdk image)
  • Waits for deployment/kmm-operator-controller to reach Available
  • Runs the DRA E2E test script (./ci/prow/e2e-dra) from the src image

The existing e2e and e2e-hub job configurations are left unchanged, with the new e2e-dra job inserted before e2e-hub.

Additionally, a review comment requested /retest.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 78c80427-5337-4836-8b3b-0b9f2aaf7a5a

📥 Commits

Reviewing files that changed from the base of the PR and between bbe352b and 91d2da0.

📒 Files selected for processing (1)
  • ci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-main.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-main.yaml

Walkthrough

A new e2e-dra Prow job is added to the kernel-module-management CI config. It uses an OpenShift 4.21 cluster claim, installs the operator bundle, waits for the controller deployment, and runs ./ci/prow/e2e-dra.

Changes

e2e-dra CI Job Addition

Layer / File(s) Summary
Add e2e-dra job
ci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-main.yaml
Adds e2e-dra with a 4.21 AWS/ocp cluster claim, install steps for openshift-kmm, the operator bundle, and controller readiness, plus a run-test step for ./ci/prow/e2e-dra.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a KMM DRA e2e test to CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only adds CI config jobs; modified files contain no Ginkgo It/Describe/Context/When titles or other dynamic test names.
Test Structure And Quality ✅ Passed PR only adds CI job YAML; no Ginkgo test code or It blocks changed, so the test-quality criteria are not applicable here.
Microshift Test Compatibility ✅ Passed Only CI config/presubmit YAML changed; no Ginkgo e2e test bodies or API-using source were added to evaluate for MicroShift.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo test code was added; this PR only wires a CI job and generated presubmit, so there are no SNO-specific multi-node assumptions to flag.
Topology-Aware Scheduling Compatibility ✅ Passed Only a new CI job was added; no deployment manifests/controllers, and no node selectors, anti-affinity, topology spread, or replica changes.
Ote Binary Stdout Contract ✅ Passed PR only adds CI job YAML; no binary or suite setup code changes that could write non-JSON stdout.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI wiring was added; the new job installs the bundle from CI artifacts and runs an existing script, with no new IPv4-specific or public-internet code in the diff.
No-Weak-Crypto ✅ Passed The PR only adds CI job config; the added lines contain no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The new e2e-dra CI job adds no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings in the modified file.
No-Sensitive-Data-In-Logs ✅ Passed The new job only adds cluster-claim metadata and command invocations; no passwords, tokens, PII, or internal hostnames are logged in the changed lines.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TomerNewman TomerNewman force-pushed the add-kmm-e2e-dra-test branch from 991b0c9 to bbe352b Compare July 6, 2026 12:02
@openshift-merge-bot openshift-merge-bot Bot added rehearsals-ack Signifies that rehearsal jobs have been acknowledged and removed rehearsals-ack Signifies that rehearsal jobs have been acknowledged labels Jul 6, 2026
@TomerNewman

Copy link
Copy Markdown
Contributor Author

/retest

@TomerNewman TomerNewman force-pushed the add-kmm-e2e-dra-test branch from bbe352b to 7a98877 Compare July 6, 2026 12:20
Add an e2e-dra test that validates the full DRA lifecycle
on an OCP 4.21 cluster (Kubernetes 1.34+ required for DRA).
@TomerNewman TomerNewman force-pushed the add-kmm-e2e-dra-test branch from 7a98877 to 91d2da0 Compare July 6, 2026 14:13
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@TomerNewman: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-rh-ecosystem-edge-kernel-module-management-main-e2e-dra rh-ecosystem-edge/kernel-module-management presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@TomerNewman

Copy link
Copy Markdown
Contributor Author

/hold
until rh-ecosystem-edge/kernel-module-management#1847 merged

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2026
@ybettan

ybettan commented Jul 7, 2026

Copy link
Copy Markdown
Member

/pj-rehearse auto-ack
This will fail until rh-ecosystem-edge/kernel-module-management#1847 isn't merged but we need to make sure this passes before merging.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ybettan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ybettan

ybettan commented Jul 7, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomerNewman, ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomerNewman

Copy link
Copy Markdown
Contributor Author

/retest

@TomerNewman

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@TomerNewman: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@TomerNewman

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@TomerNewman: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@TomerNewman

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@TomerNewman: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 8, 2026
@TomerNewman

Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2026
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@TomerNewman: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit f2021f7 into openshift:main Jul 8, 2026
17 checks passed
@TomerNewman TomerNewman deleted the add-kmm-e2e-dra-test branch July 8, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants