ROSAENG-61177 | test: add tests for identity provider commands (#3355)

Add focused tests for IDP command validators and argument validation:

- cmd/create/idp/validators_test.go: validateGitlabHostURL (HTTPS,
  scheme, query params, fragment, invalid), validateGoogleHostedDomain,
  validateLdapURL (ldap/ldaps schemes, invalid scheme, bare URL),
  validateOpenidIssuerURL (HTTPS, scheme, query params, fragment,
  invalid)
- cmd/create/idp/htpasswd_test.go: validateHtUsernameAndPassword
  (valid credentials, colon in username with message check, reserved
  cluster-admin with message check)
- cmd/dlt/idp/cmd_test.go: Args validator (zero, one, two arguments)

Skip cmd/list/idp since all logic is in run() with os.Exit and no
extracted helpers.

Author: olucasfreitas

cmd/create/idp/htpasswd_test.go

@@ -101,6 +101,25 @@ var _ = Describe("IDP Tests", func() {
 			Expect(err).To(HaveOccurred())
 		})
 	})
+
+	Describe("validateHtUsernameAndPassword", func() {
+		It("accepts a valid username and password", func() {
+			err := validateHtUsernameAndPassword("testuser", "SecureP@ssword123")
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		It("rejects a username containing a colon", func() {
+			err := validateHtUsernameAndPassword("bad:user", "SecureP@ssword123")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("username must not contain"))
+		})
+
+		It("rejects the reserved cluster-admin username", func() {
+			err := validateHtUsernameAndPassword("cluster-admin", "SecureP@ssword123")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("cluster-admin"))
+		})
+	})
 })
 
 func CreateTmpFile(content string) (*os.File, error) {

cmd/create/idp/validators_test.go

@@ -0,0 +1,107 @@
+package idp
+
+import (
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+var _ = Describe("IDP Validators", func() {
+	Context("validateGitlabHostURL", func() {
+		It("accepts a valid HTTPS URL", func() {
+			err := validateGitlabHostURL("https://gitlab.example.com")
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		It("rejects a non-HTTPS URL", func() {
+			err := validateGitlabHostURL("http://gitlab.example.com")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("https://"))
+		})
+
+		It("rejects a URL with query parameters", func() {
+			err := validateGitlabHostURL("https://gitlab.example.com?foo=bar")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("query parameters"))
+		})
+
+		It("rejects an invalid URL", func() {
+			err := validateGitlabHostURL("not-a-url")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("valid GitLab provider URL"))
+		})
+
+		It("rejects a URL with a fragment", func() {
+			err := validateGitlabHostURL("https://gitlab.example.com#section")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("valid GitLab provider URL"))
+		})
+	})
+
+	Context("validateGoogleHostedDomain", func() {
+		It("accepts a valid domain", func() {
+			err := validateGoogleHostedDomain("example.com")
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		It("rejects an invalid domain", func() {
+			err := validateGoogleHostedDomain("not a domain")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("not valid"))
+		})
+	})
+
+	Context("validateLdapURL", func() {
+		It("accepts an ldap:// URL", func() {
+			err := validateLdapURL("ldap://ldap.example.com/ou=users,dc=example,dc=com?uid")
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		It("accepts an ldaps:// URL", func() {
+			err := validateLdapURL("ldaps://ldap.example.com/ou=users,dc=example,dc=com?uid")
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		It("rejects a non-LDAP scheme", func() {
+			err := validateLdapURL("https://ldap.example.com")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("ldap://"))
+		})
+
+		It("rejects a bare URL with no scheme", func() {
+			err := validateLdapURL("ldap.com")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("expected a valid LDAP URL"))
+		})
+	})
+
+	Context("validateOpenidIssuerURL", func() {
+		It("accepts a valid HTTPS URL", func() {
+			err := validateOpenidIssuerURL("https://accounts.google.com")
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		It("rejects a non-HTTPS URL", func() {
+			err := validateOpenidIssuerURL("http://accounts.google.com")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("https://"))
+		})
+
+		It("rejects a URL with query parameters", func() {
+			err := validateOpenidIssuerURL("https://accounts.google.com?foo=bar")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("query parameters"))
+		})
+
+		It("rejects an invalid URL", func() {
+			err := validateOpenidIssuerURL("not-a-url")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("valid OpenID issuer URL"))
+		})
+
+		It("rejects a URL with a fragment", func() {
+			err := validateOpenidIssuerURL("https://accounts.google.com#section")
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("valid OpenID issuer URL"))
+		})
+	})
+})

cmd/dlt/idp/cmd_test.go

@@ -0,0 +1,27 @@
+package idp
+
+import (
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+var _ = Describe("Delete IDP", func() {
+	Context("Args validator", func() {
+		It("rejects zero arguments", func() {
+			err := Cmd.Args(nil, []string{})
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("Expected exactly one"))
+		})
+
+		It("accepts exactly one argument", func() {
+			err := Cmd.Args(nil, []string{"github-1"})
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		It("rejects two arguments", func() {
+			err := Cmd.Args(nil, []string{"github-1", "extra"})
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("Expected exactly one"))
+		})
+	})
+})

cmd/dlt/idp/idp_suite_test.go

@@ -0,0 +1,13 @@
+package idp
+
+import (
+	"testing"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+func TestDeleteIdp(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Delete IDP Suite")
+}