Merge pull request #3675 from sosiouxme/20260623-agent-updates

expand agent instructions

Author: openshift-merge-bot[bot]

.apm/instructions/backend.instructions.md

@@ -5,5 +5,8 @@ applyTo: "**/*.go"
 
 * When adding or updating APIs, **use HATEOAS** in responses to support discoverability and consistent client interaction.
 * Follow idiomatic Go practices.
+* Use `k8s.io/apimachinery/pkg/util/sets` (e.g. `sets.NewString()`) to deduplicate or collect unique strings. Do not use `map[string]bool` as a hand-rolled set.
+* Prefer structured logging where it makes sense; particularly for names and IDs, and often for
+  counts, a log.WithField() call is preferred over formatting values into a string.
 * After making changes, always run `gofmt -w` on modified files to ensure proper formatting.
 * When modifying any data provider (BigQuery or PostgreSQL), ensure **parity between both implementations**. Changes to query logic, filtering, or returned data in one provider must be reflected in the other.

.apm/instructions/docs.instructions.md

@@ -18,5 +18,6 @@ applyTo: "**"
   purpose, data flow, and key code locations; keep them accurate as
   the implementation evolves. If you add a new major feature, create a
   new doc in `docs/features/`.
-* Documentation and code belong in the same PR — never treat a docs update
+* Documentation and code belong in the same PR; never treat a docs update
   as a follow-up task.
+* Do not use em dashes when writing docs. Use commas, parentheses, or periods instead.

.apm/instructions/testing.instructions.md

@@ -4,4 +4,11 @@ applyTo: "**/*_test.go"
 ---
 
 * Use `go vet` and `go test ./pkg/...` to validate changes before resorting to a full e2e run.
-* Run `make e2e 2>&1 | tee e2e-test.log` to verify your changes don't break end-to-end tests. You **MUST** read the log file (`e2e-test.log`) for results. Do not re-run e2e just to grep for different things — all output is already in the log file.
+* Run `make e2e 2>&1 | tee e2e-test.log` to verify your changes don't break end-to-end tests. You **MUST** read the log file (`e2e-test.log`) for results. Do not re-run e2e just to grep for different things. All output is already in the log file.
+* Do not mock storage clients (BigQuery, GCS, Postgres, etc.) when constructing golang unit tests.
+  Go does not make it easy to substitute mocks for concrete SDK clients, and mock-heavy tests tend
+  to verify the mock implementation rather than real behavior. Instead, structure code to separate
+  pure logic from client calls. Unit test the logic functions directly (validation, data
+  transformation, result aggregation and analysis). Enable testing against real storage systems with
+  functional tests that skip unless the user supplies connection credentials via environment
+  variables (see `releasesync_functional_test.go` for the pattern).

.claude/rules/backend.md

@@ -104,13 +104,13 @@ local_deployed_file_hashes:
   .claude/commands/sippy-generate-release-views.md: sha256:eb4c9eeeea2ab2a90e8a8839147d8a1a309ea6ce3dafd397c6d2485c93068a9a
   .claude/commands/sippy-update-ga-release-views.md: sha256:4a5589bacc05127e427a2de4d34a8f13e05e297bdf6ebf7473c9e71f47a6b4f4
   .claude/commands/sippy-update-job-variant.md: sha256:f88742dddeec5024931959a8330fdce362ffdd9b8825e808830ac346605cbd16
-  .claude/rules/backend.md: sha256:c57f9ef479340d977f06266779cacc8cd0a67cf045a58d30757a0c494354081a
+  .claude/rules/backend.md: sha256:b1bd6bacccc8bfc8ab2c060496fede3bdcece46b59cf218cd7cddc3617ead4c5
   .claude/rules/config.md: sha256:96c5e42c039230f1e4e7f9ba56d04e6f76f23deeecdd858634c440d6029a6a83
   .claude/rules/dev-commands.md: sha256:eb32bdc640add2044138807572ea1afb73ee1bba038f5098032a89987a7ddc04
   .claude/rules/frontend.md: sha256:ff22046c5b951769218bbdf36499e67c70896811b8ef161ca6d3729a3423997d
   .claude/rules/general.md: sha256:997f68e86cb43485ec5f108be3417f9bbb43ae1faffd660d598f18260f5df3ce
   .claude/rules/mcp.md: sha256:ddfe965e7cf8cddbba1374c6ae582a20ac0af17c958bf10e1a4edff6ff2ad0b8
-  .claude/rules/testing.md: sha256:57834092f6732d17f8c1812d25290cfc1cfbbbeb6eae1561ba2240973c651866
+  .claude/rules/testing.md: sha256:52bfc6e67b38d17b767d34c480530cd14c700ef8018d5c70c2deaa7133717904
   .cursor/commands/agentic-followup.md: sha256:e7002eb10bcec06fe7e12924e52b3991572f25e2884873d7297243bc5e9720f0
   .cursor/commands/agentic-solve.md: sha256:080b152d6089be34d7cd2fac0845b312e99cae9039fc8353eeccab4b1ce78663
   .cursor/commands/sippy-dev-app.md: sha256:656276ed961940c137dde32ecdb0501427d4d811502a27125ba073adc770d266
@@ -124,13 +124,13 @@ local_deployed_file_hashes:
   .cursor/commands/sippy-generate-release-views.md: sha256:eb4c9eeeea2ab2a90e8a8839147d8a1a309ea6ce3dafd397c6d2485c93068a9a
   .cursor/commands/sippy-update-ga-release-views.md: sha256:4a5589bacc05127e427a2de4d34a8f13e05e297bdf6ebf7473c9e71f47a6b4f4
   .cursor/commands/sippy-update-job-variant.md: sha256:f88742dddeec5024931959a8330fdce362ffdd9b8825e808830ac346605cbd16
-  .cursor/rules/backend.mdc: sha256:fb466b896d76ea1730c23d6c3fc783adf2cd5502c1cbb36e5b3d30c01531e4c1
+  .cursor/rules/backend.mdc: sha256:5ff740fc76c25ee64beb7f768399da6ef6510ecca8147e5c2f81fbb110043084
   .cursor/rules/config.mdc: sha256:d6e2195399bbb26a3fef7e54bd01862ffce39d89dce8aabdb0b89c89028192eb
   .cursor/rules/dev-commands.mdc: sha256:3dc8a3ef5cbb22ebb09b7fe3785f24a32ab2baa4488c5514c9c6210b0af6c4eb
   .cursor/rules/frontend.mdc: sha256:497f39372724f1ae127181fe3dac9ea9a95a51c532b68ccfee6080832cf9c556
   .cursor/rules/general.mdc: sha256:5bc6e1e12d53d85656248c9dc1239c74bcc0df29d5987f3b08e3d79e3df413b7
   .cursor/rules/mcp.mdc: sha256:c02472afd46e4c89f71d4487dcd5da98b0c1bcbcf7f9cbc4d7ed4e7d3a206ec1
-  .cursor/rules/testing.mdc: sha256:e5ce80313a812750404d45355b462c2e3a6458f5bc20ad7996a5da1b169a4703
+  .cursor/rules/testing.mdc: sha256:12ea7763599eb56fdd92ae09a9fed19495b17673ee34701803a6eae7ac50d3e8
   .gemini/commands/agentic-followup.toml: sha256:2488d008e80c8827e365bfa1c63ba7e4ad1aa1a8141233cf72cf05aaae96f2f0
   .gemini/commands/agentic-solve.toml: sha256:09df5f8279bba3c08e780d9bcc0907308a11a19071008561b6870c8bc65a63e4
   .gemini/commands/sippy-dev-app.toml: sha256:fc28174eeab4e440694a823bd838d429241997a018d8a13f32e0f67ca4d973c5