fix: address Mansi's review comments on cli.go

- Remove noNamespace bool; use namespace == "" check instead
- Use filepath.Join for default kubeconfig path

Author: weinliu

test/extended/utils/cli.go

@@ -5,15 +5,15 @@ import (
 	"fmt"
 	"os"
 	"os/exec"
+	"path/filepath"
 	"strings"
 )
 
 // CLI wraps the oc command-line tool for use in OTE Ginkgo tests.
 type CLI struct {
-	namespace   string
-	asAdmin     bool
-	noNamespace bool
-	kubeconfig  string
+	namespace  string
+	asAdmin    bool
+	kubeconfig string
 }
 
 // NewCLI creates a CLI instance with the given namespace.
@@ -27,8 +27,7 @@ func NewCLI(namespace string) *CLI {
 // NewCLIWithoutNamespace creates a CLI instance without a namespace (for cluster-scoped resources).
 func NewCLIWithoutNamespace() *CLI {
 	return &CLI{
-		noNamespace: true,
-		kubeconfig:  kubeconfig(),
+		kubeconfig: kubeconfig(),
 	}
 }
 
@@ -45,9 +44,7 @@ func (c *CLI) Run(verb string, args ...string) (string, string, error) {
 	if c.asAdmin {
 		cmdArgs = append(cmdArgs, "--as=system:admin")
 	}
-	if c.noNamespace {
-		// no -n flag
-	} else if c.namespace != "" {
+	if c.namespace != "" {
 		cmdArgs = append(cmdArgs, "-n", c.namespace)
 	}
 	cmdArgs = append(cmdArgs, args...)
@@ -78,5 +75,5 @@ func kubeconfig() string {
 	if kc := os.Getenv("KUBECONFIG"); kc != "" {
 		return kc
 	}
-	return os.Getenv("HOME") + "/.kube/config"
+	return filepath.Join(os.Getenv("HOME"), ".kube", "config")
 }