Skip to content

Fix OpenESP8266 multi-channel PWM #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
divadiow wants to merge 8 commits into
base: main
Choose a base branch
from
+354 −22
Open

Fix OpenESP8266 multi-channel PWM #2107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
973110b
Update hal_pins_espidf.c
divadiow May 9, 2026
6f5fe2e
Update hal_pins_espidf.c
divadiow May 9, 2026
20e765d
8266 pwm finalise
divadiow May 9, 2026
f57d288
Update new_pins.c
divadiow May 9, 2026
dddbccd
Always apply ESP8266 PWM duty updates
divadiow May 10, 2026
82bf9a8
Keep ESP8266 PWM grouping inside HAL
divadiow May 18, 2026
27a7b40
Restore explicit ESP8266 PWM setup boundary
divadiow May 20, 2026
f5b691f
Batch ESP8266 PWM runtime duty updates
divadiow May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/cmnds/cmd_newLEDDriver.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,10 @@ void LED_RunQuickColorLerp(int deltaMS) {
int target_value_brightness = 0;
int target_value_cold_or_warm = 0;

#if PLATFORM_ESP8266
HAL_PIN_PWM_BeginUpdate();
#endif

if (CFG_HasFlag(OBK_FLAG_LED_FORCE_MODE_RGB)) {
// only allow setting pwm 0, 1 and 2, force-skip 3 and 4
maxPossibleIndexToSet = 3;
Expand Down Expand Up @@ -405,6 +409,9 @@ void LED_RunQuickColorLerp(int deltaMS) {
}
}
}
#if PLATFORM_ESP8266
HAL_PIN_PWM_EndUpdate();
#endif

LED_I2CDriver_WriteRGBCW(led_rawLerpCurrent);
}
Expand Down Expand Up @@ -554,6 +561,9 @@ void apply_smart_light() {
int value_brightness = 0;
int value_cold_or_warm = 0;

#if PLATFORM_ESP8266
HAL_PIN_PWM_BeginUpdate();
#endif

firstChannelIndex = LED_GetFirstChannelIndex();

Expand Down Expand Up @@ -681,6 +691,9 @@ void apply_smart_light() {
}
}
}
#if PLATFORM_ESP8266
HAL_PIN_PWM_EndUpdate();
#endif
if(CFG_HasFlag(OBK_FLAG_LED_SMOOTH_TRANSITIONS) == false) {
LED_I2CDriver_WriteRGBCW(finalColors);
}
Expand Down
Loading
Loading