[COMMON] separate JndiClient from MBeanClient#1679
Merged
chia7712 merged 1 commit intoopensource4you:mainfrom Apr 28, 2023
Merged
[COMMON] separate JndiClient from MBeanClient#1679chia7712 merged 1 commit intoopensource4you:mainfrom
chia7712 merged 1 commit intoopensource4you:mainfrom
Conversation
Contributor
Author
|
@qoo332001 @chinghongfang 麻煩看一下這隻PR，由於現在你們兩個的工作都會遇到 metrics 的重構 ( @qoo332001 你的部分來自於 #1665 (comment)) 這隻PR用來幫忙推進一些進度，如果你們沒啥反應的話，隨後我也會將 #1665 (comment) 提到的事情解決 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metrics 在獨立成另一個服務後，理論上我們的 code base 應該要避免直接使用 jndi，這隻PR先將 jndi 的邏輯從
MBeanClient中抽離出來，隨後在適當的時機會將其改成 private (只用於 metrics fetcher)