scp: avoid reconnecting to identical remote sources#698
Open
peripherium wants to merge 1 commit into
Open
Conversation
peripherium
force-pushed
the
fix/scp-reuse-connection
branch
from
July 10, 2026 15:43
5c6153d to
84e54c5
Compare
Reuse an existing SSH connection when consecutive remote source arguments refer to the same user, host and port. This avoids unnecessary reconnections during remote-to-remote copies while preserving existing behaviour.
peripherium
force-pushed
the
fix/scp-reuse-connection
branch
from
July 10, 2026 18:17
84e54c5 to
2b66f92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the existing XXX in
scp.cto reuse an SSH connection when the source user, host and port remain unchanged.When processing multiple remote source arguments (e.g.
scp -3 hosta:/foo hosta:/bar hostb:), scp currently reconnects to the same source host for each argument. This change reuses the existing connection until the source changes, avoiding unnecessary reconnects while preserving existing behaviour.One question while working on this:
tolocal()appears to exhibit similar behaviour when copying multiple files from the same remote host/user, reconnecting for each argument. Is there a reason for this, or would a similar optimisation there also be welcome?