Use PIN from refresh URI when taking login session#535
Draft
bukka wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Jakub Zelenka <jakub.openssl@gmail.com>
b3b309d to
db37671
Compare
Collaborator
|
This looks reasonable, but it also absolutely needs some tests if at all possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If multiple slots with different PINs are used and the pins are provided in uri using pin-value query param, then it doesn't work, then it might not get correctly the open session. With the current code it's more theoretical as there is not sessions refreshing needed but I saw it when I did session refreshing.
I will think about this more if it really makes sense actually.
Checklist
Reviewer's checklist: