Skip to content

Use PIN from refresh URI when taking login session#535

Draft
bukka wants to merge 1 commit into
openssl-projects:mainfrom
bukka:uri-pin-preserving
Draft

Use PIN from refresh URI when taking login session#535
bukka wants to merge 1 commit into
openssl-projects:mainfrom
bukka:uri-pin-preserving

Conversation

@bukka
Copy link
Copy Markdown
Contributor

@bukka bukka commented Mar 10, 2025

Description

If multiple slots with different PINs are used and the pins are provided in uri using pin-value query param, then it doesn't work, then it might not get correctly the open session. With the current code it's more theoretical as there is not sessions refreshing needed but I saw it when I did session refreshing.

I will think about this more if it really makes sense actually.

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

Signed-off-by: Jakub Zelenka <jakub.openssl@gmail.com>
@bukka bukka force-pushed the uri-pin-preserving branch from b3b309d to db37671 Compare March 10, 2025 15:46
@simo5
Copy link
Copy Markdown
Collaborator

simo5 commented Mar 10, 2025

This looks reasonable, but it also absolutely needs some tests if at all possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants