Add a couple of tests to build on ARM-64#623
Conversation
28faf42 to
3cc5bae
Compare
|
Depends on #630 |
OpenSSL embedded some TLS specific de-padding and MAC handling into the actual ciphers ... this is crazy, but whatever. This commit implements manual de-padding and then MAC extraction in constant time. I believe this is used in rare cases for MAC-then-Encrypt cases and it is normally not exercised much, but TLS-Fuzzer does exercise these corner cases and was failing tests when using latest OpenSSL with CIPHER EVP_SKEY enabled in pkcs11-provider. Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Simo Sorce <simo@redhat.com>
This allows us to do some testing on another arch to catch arch-spciecifc bugs if any. Signed-off-by: Simo Sorce <simo@redhat.com>
|
Given the name of the test changed (as matrix test automatically add all matrix options in the name) the CI is not marking this as ready. I will try to reconfigure the project to require the new test names. @Jakuje if you could approve, in the meanwhile, that would be nice |
Instead of the need to reconfigure the GH action names in the GitHub WebUI, its possible to define a one job that will depend on the jobs you need to succeed, similarly as we did it here (with the expansion of the matrix): parallaxsecond/rust-cryptoki#286 But given that the mandatory list is still quite short, I think we are good.
Just one inline comment, otherwise lgtm |
Yeah, I had to touch this like twice since the project was started so it is not a thing I want to spend time optimizing right now. Should this change we can deal with it later. |
Description
Checklist
[ ] Code modified for feature[ ] Test suite updated with negative tests[ ] Documentation updatedReviewer's checklist: