Skip to content

Add a couple of tests to build on ARM-64#623

Merged
simo5 merged 3 commits into
openssl-projects:mainfrom
simo5:arm64
Sep 10, 2025
Merged

Add a couple of tests to build on ARM-64#623
simo5 merged 3 commits into
openssl-projects:mainfrom
simo5:arm64

Conversation

@simo5
Copy link
Copy Markdown
Collaborator

@simo5 simo5 commented Sep 2, 2025

Description

Checklist

  • [ ] Code modified for feature
  • Test suite updated with functionality tests
  • [ ] Test suite updated with negative tests
  • [ ] Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@simo5 simo5 force-pushed the arm64 branch 8 times, most recently from 28faf42 to 3cc5bae Compare September 9, 2025 20:33
@simo5
Copy link
Copy Markdown
Collaborator Author

simo5 commented Sep 9, 2025

Depends on #630

Comment thread .github/workflows/build.yml Outdated
OpenSSL embedded some TLS specific de-padding and MAC handling into the
actual ciphers ... this is crazy, but whatever.

This commit implements manual de-padding and then MAC extraction in
constant time.

I believe this is used in rare cases for MAC-then-Encrypt cases and it
is normally not exercised much, but TLS-Fuzzer does exercise these
corner cases and was failing tests when using latest OpenSSL with
CIPHER EVP_SKEY enabled in pkcs11-provider.

Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Simo Sorce <simo@redhat.com>
This allows us to do some testing on another arch to catch
arch-spciecifc bugs if any.

Signed-off-by: Simo Sorce <simo@redhat.com>
@simo5 simo5 added the covscan-not-needed Covscan is not needed for this PR label Sep 10, 2025
@simo5
Copy link
Copy Markdown
Collaborator Author

simo5 commented Sep 10, 2025

Given the name of the test changed (as matrix test automatically add all matrix options in the name) the CI is not marking this as ready. I will try to reconfigure the project to require the new test names.

@Jakuje if you could approve, in the meanwhile, that would be nice

Comment thread .github/workflows/build.yml
@Jakuje
Copy link
Copy Markdown
Collaborator

Jakuje commented Sep 10, 2025

Given the name of the test changed (as matrix test automatically add all matrix options in the name) the CI is not marking this as ready. I will try to reconfigure the project to require the new test names.

Instead of the need to reconfigure the GH action names in the GitHub WebUI, its possible to define a one job that will depend on the jobs you need to succeed, similarly as we did it here (with the expansion of the matrix):

parallaxsecond/rust-cryptoki#286

But given that the mandatory list is still quite short, I think we are good.

@Jakuje if you could approve, in the meanwhile, that would be nice

Just one inline comment, otherwise lgtm

@simo5
Copy link
Copy Markdown
Collaborator Author

simo5 commented Sep 10, 2025

Instead of the need to reconfigure the GH action names in the GitHub WebUI, its possible to define a one job that will depend on the jobs you need to succeed, similarly as we did it here (with the expansion of the matrix):

parallaxsecond/rust-cryptoki#286

But given that the mandatory list is still quite short, I think we are good.

Yeah, I had to touch this like twice since the project was started so it is not a thing I want to spend time optimizing right now. Should this change we can deal with it later.

@simo5 simo5 merged commit 37faece into openssl-projects:main Sep 10, 2025
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

covscan-not-needed Covscan is not needed for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants