[stable/yoga] Fix designate-bind ServiceIPs test wait states#1398
Open
xtrusia wants to merge 3 commits into
Open
[stable/yoga] Fix designate-bind ServiceIPs test wait states#1398xtrusia wants to merge 3 commits into
xtrusia wants to merge 3 commits into
Conversation
xtrusia
changed the title
xtrusia
force-pushed
the
fix-designate-bind-serviceips-wait-states
branch
from
cdb235a to
2ca6639
Compare
There are scenarios where the config-changed hook can complete, yet the service IP get configured many seconds after, because a relation-changed hook execution needs to be triggered on the hacluster side of the relation. This change adds a retry to the check (10 times with a 2 seconds wait time). This issue was found at the gate https://review.opendev.org/c/openstack/charm-designate-bind/+/861417 (cherry picked from commit d083dde)
Similar to when an IP has been added to the service_ips earlier in test_configure_ips(), this adds tenacity Retrying after an IP has been removed from the service_ips. (cherry picked from commit 080a715)
Pass target_deploy_status so blocked nrpe is tolerated. Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com> (cherry picked from commit 8e96802)
xtrusia
force-pushed
the
fix-designate-bind-serviceips-wait-states
branch
from
2ca6639 to
58f1dcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_configure_ips called wait_for_application_states() with no states, requiring every application active. nrpe is related only to designate (no nagios) so it stays blocked and the wait times out under juju 3.6. Pass target_deploy_status from tests.yaml, matching what DesignateBindExpand already does.