Skip to content

[stable/antelope] Fix designate-bind ServiceIPs test wait states #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xtrusia wants to merge 2 commits into
base: stable/antelope
Choose a base branch
from
Open

[stable/antelope] Fix designate-bind ServiceIPs test wait states #1401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b410557
Retry assert after service_ips removal
Apr 18, 2023
35c9b20
Fix designate-bind ServiceIPs test wait states
xtrusia Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions zaza/openstack/charm_tests/designate_bind/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
)

import zaza.model as zaza_model
import zaza.charm_lifecycle.utils as lifecycle_utils
import zaza.openstack.charm_tests.test_utils as test_utils


Expand All @@ -44,26 +45,32 @@ def setUp(self):
def test_configure_ips(self):
"""Configure and un-configure 'service_ips' option."""
config = {"service_ips": self.VIP}
test_config = lifecycle_utils.get_charm_config(fatal=False)
states = test_config.get("target_deploy_status", {})

logging.info("Configuring %s as a Service IP for %s unit.",
self.VIP, self.UNIT)
zaza_model.set_application_config(self.APPLICATION, config)
zaza_model.wait_for_application_states()
zaza_model.wait_for_application_states(states=states)

for attempt in Retrying(wait=wait_fixed(2),
retry=retry_if_exception_type(AssertionError),
reraise=True,
stop=stop_after_attempt(10)):
with attempt:
configured_ips = zaza_model.run_on_unit(self.UNIT,
"ip addr")
configured_ips = zaza_model.run_on_unit(self.UNIT, "ip addr")
self.assertIn(self.VIP, configured_ips["Stdout"])

logging.info("Removing service IP configuration from %s unit.",
self.UNIT)
config["service_ips"] = ""
zaza_model.set_application_config(self.APPLICATION, config)
zaza_model.wait_for_application_states()
zaza_model.wait_for_application_states(states=states)

configured_ips = zaza_model.run_on_unit(self.UNIT, "ip addr")
self.assertNotIn(self.VIP, configured_ips["Stdout"])
for attempt in Retrying(wait=wait_fixed(2),
Comment thread
xtrusia marked this conversation as resolved.
retry=retry_if_exception_type(AssertionError),
reraise=True,
stop=stop_after_attempt(10)):
with attempt:
configured_ips = zaza_model.run_on_unit(self.UNIT, "ip addr")
self.assertNotIn(self.VIP, configured_ips["Stdout"])
Loading