Convert TEST_*_PROXY to *_proxy env vars#1409
Open
dosaboy wants to merge 1 commit into
Open
Conversation
dosaboy
force-pushed
the
set-http-proxy-neuton-libs
branch
from
b5b3a8a to
eb0f4db
Compare
freyes
requested changes
Jul 3, 2026
| "fip_service_subnet_cidr": "100.64.0.0/24" | ||
| } | ||
|
|
||
| # Set proxy vars if provided so that all code gets to use it. |
Member
There was a problem hiding this comment.
setting this at module definition level will make all code after this to get the side effect of setting these env variable.
This is a side effect that shouldn't escape this module's scope, although if that's an intentional behavior, I think it should be defined in zaza/openstack/__init__.py so this gets set no matter when/what imported this code ... and even in that scenario sounds easy to get into weirdness
Contributor
Author
There was a problem hiding this comment.
ah yes i like that, ill move it
If TEST_{NO,HTTP,HTTPS}_PROXY are provided, convert them to
http_proxy etc so that code will use them. This will apply
to all code under zaza.openstack.
dosaboy
force-pushed
the
set-http-proxy-neuton-libs
branch
from
eb0f4db to
4b4ecec
Compare
dosaboy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If TEST_{NO,HTTP,HTTPS}_PROXY are provided, convert them to
http_proxy etc so that code will use them. This will apply
to all code under zaza.openstack.