[stable/antelope] Use zaza.model.run_on_unit for ca checks#1411
Open
xtrusia wants to merge 1 commit into
Open
Conversation
Existing code uses the python libjuju unit.run in order to execute a wait check for ca readiness across the units. The behavior of libjuju changed between 2.x and 3.x and causes this functionality to break. This is abstracted and handled in the zaza library, so use that code instead as it properly handles the differences. Signed-off-by: Billy Olsen <billy.olsen@canonical.com> (cherry picked from commit a64d2c6) Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1192.
async_block_until_ca_exists uses libjuju unit.run to read the CA file on the units. The result structure of unit.run changed between libjuju 2.x and 3.x, so the results come back as None and the CA readiness check raises AttributeError, breaking vault setup under juju 3.x. Switch to zaza.model.run_on_unit which handles the version difference. Already on master, stable/caracal, stable/yoga and stable/zed.