Rewrite merged-requirements files in func-test-pr#350
Open
xtrusia wants to merge 1 commit into
Open
Conversation
The func-test-pr role only rewrites test-requirements*.txt files. Charms migrated to the ci-cleanup layout install their func-target tox env from merged-requirements-py*.txt via the base testenv, so rewriting test-requirements*.txt has no effect and the func-test-pr pin change never reaches the installed zaza. Add merged-requirements*.txt to the globbed file list so the rewrite reaches the file that is actually installed. Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com>
xtrusia
force-pushed
the
func-test-pr-merged-requirements
branch
from
5385808 to
f86abe8
Compare
xtrusia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The func-test-pr role only rewrites test-requirements*.txt files.
Charms migrated to the ci-cleanup layout install their func-target tox env from merged-requirements-py*.txt via the base testenv, so rewriting test-requirements*.txt has no effect and the func-test-pr pin change never reaches the installed zaza.
Add merged-requirements*.txt to the globbed file list so the rewrite reaches the file that is actually installed.