Skip to content

Commit fed27da

Browse files
committed
nova04/vfio: fix storage class overriding
The storage lib component relies on network-values data for setting control plane SC values, historically. The replacement of telemetry data overrides this in the nova04delta and vfio DT/VA. Fixing that by re-applying the storage component logic locally in the DT/VA as well, while repurposing it to control-plane data instead of network-values didn't work in CI (however, it works locally with kustomize build). Fix that by simply providing pvcStorageClass directly in DT/VA. We would not have to fix that, if T-O had been taking the top scope storageClass for its metricStorage template (that fix will be in FR5 likely). Signed-off-by: Bohdan Dobrelia <bdobreli@redhat.com>
1 parent 5208198 commit fed27da

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

examples/dt/nova/nova04delta/control-plane/service-values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ data:
5252
scrapeInterval: 30s
5353
storage:
5454
persistent:
55-
# NOTE: pvcStorageClass is defined in control-plane/networking/nncp/values.yaml network-values data.storageClass
55+
pvcStorageClass: local-storage
5656
pvcStorageRequest: 20G
5757
pvcStorageSelector: {}
5858
retention: 24h

examples/va/nvidia-vfio-passthrough/control-plane/service-values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ data:
5252
scrapeInterval: 30s
5353
storage:
5454
persistent:
55-
# NOTE: pvcStorageClass is defined in control-plane/networking/nncp/values.yaml network-values data.storageClass
55+
pvcStorageClass: local-storage
5656
pvcStorageRequest: 20G
5757
pvcStorageSelector: {}
5858
retention: 24h

0 commit comments

Comments
 (0)