Add databaseInstance for manila in ctlplane template#621
Merged
softwarefactory-project-zuul[bot] merged 1 commit intoSep 18, 2025
Merged
Conversation
There seems to be a bug in the current controller-gen version used, which resulted in the databaseInstance in manila not to be a required paramater. With the bump controller-gen happening as part of the golang-bump work the databaseInstance gets added as a required parameter [1]. This adds it to the ctlplane template. [1] openstack-k8s-operators/manila-operator#462 (comment) Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
requested review from
abays and
fmount
and removed request for
karelyatin and
leifmadsen
Contributor
Author
|
in running a test the ctlplane deployed ok with this |
abays
added
the
testing-complete
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fmount, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
softwarefactory-project-zuul
Bot
merged commit 8b04b60
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a bug in the current controller-gen version used, which resulted in the databaseInstance in manila not to be a required paramater.
With the bump controller-gen happening as part of the golang-bump work the databaseInstance gets added as a required parameter [1]. This adds it to the ctlplane template.
[1] openstack-k8s-operators/manila-operator#462 (comment)