[DCN] Adding cinderBackups to controlplane by gais-ameer-rh · Pull Request #762 · openstack-k8s-operators/architecture

gais-ameer-rh · 2026-05-26T09:51:50Z

To deploy multiple cinder backups distributed across edge sites

Removes the existing spec.cinder.template.cinderBackup (singluar) by setting repliacs to 0 and adds cinderBackups (plural)

Jira: OSPRH-28343
Signed-off-by: Gais Ameer gameer@redhat.com

openshift-ci · 2026-05-26T09:51:57Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gais-ameer-rh
Once this PR has been reviewed and has the lgtm label, please assign raukadah for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-05-26T09:52:02Z

Hi @gais-ameer-rh. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fultonj · 2026-05-26T18:36:31Z

This looks like the right idea. Let's see the testing results.

fultonj · 2026-06-12T12:25:54Z

-      backup_ceph_pool = backups
-      backup_ceph_user = openstack
+      # Not implemented in this example
+  cinderBackups:


yes, we want cinderBackups here because ceph has been deployed.

fultonj · 2026-06-12T12:26:28Z


  # --- Below are VA/DT-specific data ---
-  _change_me: later
+  cinderBackups:


I don't think we want cinderBackups here yet because ceph has not been deployed. cinderVolumes is not here either.

removed the cinderBackups from here.
But cinderBackups: {} is injected to OpenStackControlPlane CR from examples/dt/dcn/control-plane/kustomization.yaml

fultonj · 2026-06-12T12:26:37Z

  - networking/nncp/values.yaml
  - service-values.yaml
+
+replacements:


I don't think we want cinderBackups here yet because ceph has not been deployed. cinderVolumes is not here either.

I replaced these lines with patches to inject cinderBackups: {} to base OpenStackControlPlane CR.
PS: cinderBackups is not defined in lib\control-plane.

fultonj · 2026-06-15T12:24:52Z

-      backup_ceph_conf = /etc/ceph/az0.conf
-      backup_ceph_pool = backups
-      backup_ceph_user = openstack
+      # Not implemented in this example


cinderBackup (singular) is deprecated; use cinderBackups (plural)

fultonj · 2026-06-15T12:25:38Z

-      backup_ceph_conf = /etc/ceph/az0.conf
-      backup_ceph_pool = backups
-      backup_ceph_user = openstack
+      # Not implemented in this example


fultonj · 2026-06-15T12:26:35Z

Worked with test project

To deploy multiple cinder backups distributed across edge sites Removes the existing spec.cinder.template.cinderBackup (singluar) by setting repliacs to 0 and adds cinderBackups (plural) to controlplane Jira: OSPRH-28343 Signed-off-by: Gais Ameer <gameer@redhat.com>

abays

/lgtm

fultonj · 2026-06-16T10:50:16Z

Just showing the main changes from this patch.

I. control plane pre-ceph has cinderBackups set but empty:

$ cd architecture/examples/dt/dcn/control-plane
$ kustomize build . | grep -i backups
      cinderBackups: {}
$

II. control plane post-ceph has cinderBackups set correctly and a note about the deprecation:

cd architecture/examples/dt/dcn
kustomize build | grep cinder: -A 66

produces expected output:

  cinder:
    apiOverride:
      route: {}
    template:
      apiTimeout: 600
      cinderAPI:
        override:
          service:
            internal:
              metadata:
                annotations:
                  metallb.universe.tf/address-pool: internalapi
                  metallb.universe.tf/allow-shared-ip: internalapi
                  metallb.universe.tf/loadBalancerIPs: 172.17.0.80
              spec:
                type: LoadBalancer
        replicas: 3
      cinderBackup:
        customServiceConfig: |
          [DEFAULT]
          # cinderBackup (singular) is deprecated; use cinderBackups (plural)
        networkAttachments:
        - storage
        replicas: 0
      cinderBackups:
        az0:
          customServiceConfig: |
            [DEFAULT]
            storage_availability_zone = az0
            backup_driver = cinder.backup.drivers.ceph.CephBackupDriver
            backup_ceph_conf = /etc/ceph/az0.conf
            backup_ceph_pool = backups
            backup_ceph_user = openstack
          networkAttachments:
          - storage
          replicas: 2
        az1:
          customServiceConfig: |
            [DEFAULT]
            storage_availability_zone = az1
            backup_driver = cinder.backup.drivers.ceph.CephBackupDriver
            backup_ceph_conf = /etc/ceph/az1.conf
            backup_ceph_pool = backups
            backup_ceph_user = openstack
          networkAttachments:
          - storage
          replicas: 2
        az2:
          customServiceConfig: |
            [DEFAULT]
            storage_availability_zone = az2
            backup_driver = cinder.backup.drivers.ceph.CephBackupDriver
            backup_ceph_conf = /etc/ceph/az2.conf
            backup_ceph_pool = backups
            backup_ceph_user = openstack
          networkAttachments:
          - storage
          replicas: 2
      cinderScheduler:
        replicas: 1
      cinderVolumes:
        az0:
          customServiceConfig: |
            [DEFAULT]
            enabled_backends = ceph
            glance_api_servers = https://glance-az0-internal.openstack.svc:9292
            [ceph]

III. scale down

cd architecture/examples/dt/dcn/control-plane/scaledown
kustomize build . | grep cinderBackups -A 33

has expected output (replicas set to 0 because we're scaling down).

          # cinderBackup (singular) is deprecated; use cinderBackups (plural)
        networkAttachments:
        - storage
        replicas: 0
      cinderBackups:
        az0:
          customServiceConfig: |
            [DEFAULT]
            storage_availability_zone = az0
            backup_driver = cinder.backup.drivers.ceph.CephBackupDriver
            backup_ceph_conf = /etc/ceph/az0.conf
            backup_ceph_pool = backups
            backup_ceph_user = openstack
          networkAttachments:
          - storage
          replicas: 2
        az1:
          customServiceConfig: |
            [DEFAULT]
            storage_availability_zone = az1
            backup_driver = cinder.backup.drivers.ceph.CephBackupDriver
            backup_ceph_conf = /etc/ceph/az1.conf
            backup_ceph_pool = backups
            backup_ceph_user = openstack
          networkAttachments:
          - storage
          replicas: 0
        az2:
          customServiceConfig: |
            [DEFAULT]
            storage_availability_zone = az2
            backup_driver = cinder.backup.drivers.ceph.CephBackupDriver
            backup_ceph_conf = /etc/ceph/az2.conf
            backup_ceph_pool = backups
            backup_ceph_user = openstack
          networkAttachments:
          - storage
          replicas: 2

fultonj · 2026-06-16T10:51:58Z

Let's merge the following first:

openstack-k8s-operators/ci-framework#3963

openshift-ci Bot added the do-not-merge/work-in-progress label May 26, 2026

openshift-ci Bot added the needs-ok-to-test label May 26, 2026

fultonj self-requested a review May 26, 2026 18:21

gais-ameer-rh force-pushed the OSPRH-28343 branch 5 times, most recently from 8417cf5 to c339136 Compare June 11, 2026 11:52

fultonj reviewed Jun 12, 2026

View reviewed changes

gais-ameer-rh force-pushed the OSPRH-28343 branch 3 times, most recently from 524c85b to d441bfb Compare June 15, 2026 08:09

fultonj reviewed Jun 15, 2026

View reviewed changes

fultonj added ok-to-test and removed do-not-merge/work-in-progress needs-ok-to-test labels Jun 15, 2026

gais-ameer-rh force-pushed the OSPRH-28343 branch from d441bfb to 5b9c06d Compare June 15, 2026 17:10

fultonj marked this pull request as ready for review June 16, 2026 10:38

openshift-ci Bot requested review from abays and raukadah June 16, 2026 10:38

abays reviewed Jun 16, 2026

View reviewed changes

openshift-ci Bot assigned abays Jun 16, 2026

openshift-ci Bot added the lgtm label Jun 16, 2026

fultonj removed the request for review from raukadah June 16, 2026 10:55

Conversation

gais-ameer-rh commented May 26, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented May 26, 2026

Uh oh!

openshift-ci Bot commented May 26, 2026

Uh oh!

fultonj commented May 26, 2026

Uh oh!

fultonj Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

fultonj Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

gais-ameer-rh Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

fultonj Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

gais-ameer-rh Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fultonj Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

gais-ameer-rh Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

fultonj Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gais-ameer-rh Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

fultonj commented Jun 15, 2026

Uh oh!

abays left a comment

Choose a reason for hiding this comment

Uh oh!

fultonj commented Jun 16, 2026

Uh oh!

fultonj commented Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gais-ameer-rh commented May 26, 2026 •

edited by openshift-ci Bot

Loading

gais-ameer-rh Jun 12, 2026 •

edited

Loading

fultonj Jun 15, 2026 •

edited

Loading