Fix/nfv controlplane novnc and metricstorage#770
Open
aharivel wants to merge 2 commits into
Open
Conversation
The base OpenStackControlPlane defines cell1 without a noVNCProxyServiceTemplate, which means VNC console access to VMs scheduled on cell1 compute nodes is not available. The authoritative RHOSO documentation specifies that cell1 should include noVNCProxyServiceTemplate with enabled: true and a ctlplane network attachment. Without this, operators must manually patch every deployment to enable console access — a common source of post-deploy debugging. This affects all validated architectures that inherit from lib/control-plane/base. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Anthony Harivel <aharivel@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aharivel The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…values The NFV OVS-DPDK-SRIOV validated architecture enables telemetry and ceilometer via service-values replacements, but metricStorage (Prometheus monitoring stack) has no replacement — it stays at the base default of enabled: false regardless of what the deployer sets in service-values. This adds a kustomize replacement for telemetry.template.metricStorage.enabled so NFV deployments can toggle Prometheus metric collection through service-values.yaml, consistent with how telemetry.enabled and ceilometer.enabled are already handled. Also adds the metricStorage.enabled field to example service-values for both ovs-dpdk-sriov and ovs-dpdk-sriov-ipv6 to satisfy the kustomize replacement source requirement and provide a working default. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
aharivel
force-pushed
the
fix/nfv-controlplane-novnc-metricstorage
branch
from
02dcdba to
ed23b12
Compare
Contributor
|
It looks ok to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two gaps in the NFV OVS-DPDK-SRIOV controlplane configuration identified by comparing rendered manifests against authoritative RHOSO component specs:
Add noVNCProxyServiceTemplate to nova cell1 (
lib/control-plane/base): The base OpenStackControlPlane defines cell1 without a noVNCProxyServiceTemplate, meaning VNC console access to VMs on cell1 compute nodes is unavailable out of the box. The authoritative RHOSO docs specifyenabled: truewith actlplanenetwork attachment. This affects all validated architectures inheriting fromlib/control-plane/base.Add metricStorage kustomize replacement (
va/nfv/ovs-dpdk-sriov): The NFV VA already exposestelemetry.enabledandceilometer.enabledvia service-values replacements, butmetricStorage.enabledhas no replacement — it staysfalseregardless of deployer intent. This adds the missing replacement so NFV deployments can toggle Prometheus metric collection throughservice-values.yaml.