Skip to content

Commit 026e6ba

Browse files
(multiple) Set test_operator as default test role
Set cifmw_run_test_role to test_operator as a default and remove redundant explicit settings from scenarios. This is an effort to deprecate the tempest role and to reduce repetition of setting this variable to test_operator almost every time. Signed-off-by: Katarina Strenkova <kstrenko@redhat.com>
1 parent 6b9caf5 commit 026e6ba

14 files changed

Lines changed: 12 additions & 14 deletions

File tree

docs/source/usage/01_usage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ are shared among multiple roles:
5353
- `cifmw_ceph_target`: (String) The Ansible inventory group where ceph is deployed. Defaults to `computes`.
5454
- `cifmw_run_tests`: (Bool) Specifies whether tests should be executed.
5555
Defaults to false.
56-
- `cifmw_run_test_role`: (String) Specifies which ci-framework role will be used to run tests. Allowed options are `test_operator`, `tempest` and `shiftstack`. Defaults to `tempest`.
56+
- `cifmw_run_test_role`: (String) Specifies which ci-framework role will be used to run tests. Allowed options are `test_operator` and `shiftstack`. Defaults to `test_operator`.
5757
- `cifmw_edpm_deploy_nfs`: (Bool) Specifies whether an nfs server should be deployed.
5858
- `cifmw_nfs_target`: (String) The Ansible inventory group where the nfs server is deployed. Defaults to `computes`. Only has an effect if `cifmw_edpm_deploy_nfs` is set to `true`.
5959
- `cifmw_nfs_network`: (String) The network the deployed nfs server will be accessible from. Defaults to `storage`. Only has an effect if `cifmw_edpm_deploy_nfs` is set to `true`.

group_vars/all.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ cifmw_default_container_image_tag: "current-podified"
4444
cifmw_master_container_image_namespace: "podified-master-centos9"
4545
cifmw_openstack_k8s_operators_org_url: "https://github.com/openstack-k8s-operators"
4646

47+
# Default test role
48+
cifmw_run_test_role: test_operator
49+
4750
#### Pinned external projects dependencies ####
4851
#
4952
# These variables define the source URL and version for

playbooks/08-run-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
tags:
2424
- tests
2525
ansible.builtin.import_role:
26-
name: "{{ cifmw_run_test_role | default('tempest') }}"
26+
name: "{{ cifmw_run_test_role | default('test_operator') }}"
2727

2828
- name: Run post_tests hooks
2929
vars:

playbooks/multi-namespace/ns2_validation.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66
tags:
77
- tests
88
ansible.builtin.import_role:
9-
name: "{{ cifmw_run_test_role | default('tempest') }}"
9+
name: "{{ cifmw_run_test_role | default('test_operator') }}"

roles/cifmw_setup/tasks/run_tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
tags:
1010
- tests
1111
ansible.builtin.import_role:
12-
name: "{{ cifmw_run_test_role | default('tempest') }}"
12+
name: "{{ cifmw_run_test_role | default('test_operator') }}"
1313
when: cifmw_run_tests | default(false) | bool
1414

1515
- name: Run post_tests hooks

roles/polarion/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Role to setup jump tool and upload XML test results to Polarion.
44
## Parameters
55
* `cifmw_polarion_basedir`: (String) Base directory. Defaults to `cifmw_basedir` which defaults to `~/ci-framework-data`.
66
* `cifmw_polarion_jump_repo_dir`: (String) Jump repo directory. Defaults to `~/ci-framework-data/polarion-jump`.
7-
* `cifmw_polarion_jump_result_dir`: (String) Test results directory. Based on `cifmw_run_test_role` defaults to `~/ci-framework-data/tests/tempest/` or `~/ci-framework-data/tests/test_operator/`.
7+
* `cifmw_polarion_jump_result_dir`: (String) Test results directory. Based on `cifmw_run_test_role` defaults to `~/ci-framework-data/tests/test_operator/`.
88
* `cifmw_polarion_jump_repo_url`: (String) URL of jump repository.
99
* `cifmw_polarion_testrun_title`: (String) A name of the test run under which the test results will be uploaded to polarion. The role appends an index number to the name to distinguish multiple test runs apart.
1010
* `cifmw_polarion_testrun_id`: (String) A test run identification provided by Polarion test case or `create-new-test-run` if polarion should generate a random test run ID. A value other than `create-new-test-run` will force this role to upload all test results found in all directories under `cifmw_polarion_jump_repo_url` to one test run identified by the given ID. The default behavior of this role is to treat the directories in `cifmw_polarion_jump_repo_url` as separate test runs.

roles/polarion/defaults/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
cifmw_polarion_basedir: "{{ cifmw_basedir }}"
2222
cifmw_polarion_jump_custom_fields: {}
2323
cifmw_polarion_jump_repo_dir: "{{ cifmw_polarion_basedir }}/polarion-jump"
24-
cifmw_polarion_jump_result_dir: "{{ cifmw_polarion_basedir }}/tests/{{ cifmw_run_test_role | default('tempest') }}/"
24+
cifmw_polarion_jump_result_dir: "{{ cifmw_polarion_basedir }}/tests/{{ cifmw_run_test_role }}/"
2525
cifmw_polarion_jump_repo_branch: "master"
2626
cifmw_polarion_testrun_title: "testrun-name"
2727
cifmw_polarion_use_stage: false

roles/reportportal/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ The `reportportal` role uses Data Router tool for uploading XML test results to
77
* `cifmw_reportportal_droute_client_url`: (String) URL of Data router client repository (mandatory).
88
* `cifmw_reportportal_datarouter_username`: (String) username for Data router client (mandatory).
99
* `cifmw_reportportal_datarouter_password`: (String) password for Data router client (mandatory).
10-
* `cifmw_reportportal_datarouter_result_dir`: (String) Test results directory. Based on `cifmw_run_test_role` defaults to `~/ci-framework-data/tests/tempest/` or `~/ci-framework-data/tests/test_operator/`. One or more properly formatted xml results files are expected to be found in this directory.
10+
* `cifmw_reportportal_results_dir`: (String) Test results directory. Based on `cifmw_run_test_role` defaults to `~/ci-framework-data/tests/test_operator/`. One or more properly formatted xml results files are expected to be found in this directory.
1111
* `cifmw_reportportal_project`: (String) Report portal project for uploading results (mandatory).
1212
* `cifmw_reportportal_launch_name`: (String) Name of the Report portal launch defaults to `Dummy launch`.
1313
* `cifmw_reportportal_launch_description`: (String) Description of the Report portal launch defaults to `Test results sent via Data router`.
14-
* `cifmw_reportportal_droute_version`: (String) Data router client version defaults to `1.2.1`.
14+
* `cifmw_reportportal_droute_version`: (String) Data router client version defaults to `latest`.
1515
* `cifmw_reportportal_droute_binary`: (String) Data router binary name defaults to `droute-linux-amd64`.
1616

1717
## Examples

roles/reportportal/defaults/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ cifmw_reportportal_results_dir: >-
1414
{{
1515
(cifmw_reportportal_basedir,
1616
'tests',
17-
cifmw_run_test_role | default('tempest')) |
17+
cifmw_run_test_role) |
1818
path_join
1919
}}
2020

scenarios/centos-9/multinode-ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,5 @@ cifmw_install_yamls_vars:
3131
cifmw_deploy_edpm: true
3232

3333
# Tempest vars
34-
cifmw_run_test_role: test_operator
3534
cifmw_test_operator_tempest_include_list: |
3635
tempest.scenario.test_network_basic_ops.TestNetworkBasicOps

0 commit comments

Comments
 (0)