[cinder_multiattach] Wait for Glance reconciliation after config patch

The oc wait --for=condition=Ready on the controlplane returns
immediately when the condition is already true, before the
StatefulSet rolling update triggered by the config change completes.
This causes a race with subsequent hooks (e.g. amphora image upload)
that depend on Glance being stable.

Replace the inline oc wait with two explicit steps:
1. Poll the Glance CR until customServiceConfig reflects the change
2. Wait for the controlplane Ready condition after reconciliation starts

Closes: OSPCIX-1454

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Francesco Pantano <fpantano@redhat.com>

Author: fmount

hooks/playbooks/cinder_multiattach_volume_type.yml

@@ -28,6 +28,16 @@
     - name: Block to configure cinder_volume_type when needed
       when: configure_cinder_volume_type | default(false) | bool
       block:
+        - name: Get OpenStackControlPlane CR name
+          environment:
+            KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}"
+            PATH: "{{ cifmw_path }}"
+          ansible.builtin.shell: |
+            set -xe -o pipefail
+            oc get openstackcontrolplane -o name -n {{ namespace }}
+          register: _ctlplane_name
+          changed_when: false
+
         - name: Create tempfile
           ansible.builtin.tempfile:
             state: file
@@ -37,8 +47,7 @@
         - name: Write current glance customServiceConfig to tempfile
           ansible.builtin.shell: |
             set -xe -o pipefail
-            crname=$(oc get openstackcontrolplane -o name -n {{ namespace }})
-            oc -n {{ namespace }} get ${crname} -o jsonpath={.spec.glance.template.customServiceConfig} > {{ _glance_custom_service_config_file.path }}
+            oc -n {{ namespace }} get {{ _ctlplane_name.stdout }} -o jsonpath={.spec.glance.template.customServiceConfig} > {{ _glance_custom_service_config_file.path }}
           changed_when: false
 
         - name: Ensure cinder_volume_type is configured with proper value in tempfile
@@ -65,8 +74,34 @@
                     customServiceConfig: "{{ _glance_ini_content.content | b64decode }}"
           ansible.builtin.shell: |
             set -xe -o pipefail
-            crname=$(oc get openstackcontrolplane -o name -n {{ namespace }})
-            oc -n {{ namespace }} patch ${crname} --type=merge --patch "{{ _yaml_patch | to_nice_yaml }}"
-            oc -n {{ namespace }} wait ${crname} --for condition=Ready --timeout=10m
+            oc -n {{ namespace }} patch {{ _ctlplane_name.stdout }} --type=merge --patch "{{ _yaml_patch | to_nice_yaml }}"
           changed_when: _glance_ini_file.changed
           when: _glance_ini_file.changed
+
+        # The controlplane patch triggers a reconciliation that propagates
+        # customServiceConfig to the Glance CR. We must confirm that the
+        # updated CR is available before waiting for Ready, otherwise oc wait
+        # returns immediately on the stale Ready=True from before the rolling
+        # update.
+        - name: Verify Glance CR reflects the cinder_volume_type change
+          environment:
+            KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}"
+            PATH: "{{ cifmw_path }}"
+          ansible.builtin.shell: |
+            set -xe -o pipefail
+            gcr=$(oc -n {{ namespace }} get glance -o custom-columns=NAME:.metadata.name --no-headers)
+            oc -n {{ namespace }} get glance ${gcr} -o jsonpath='{.spec.customServiceConfig}'
+          register: _glance_cr_config
+          retries: 30
+          delay: 5
+          until: "'cinder_volume_type' in _glance_cr_config.stdout"
+          when: _glance_ini_file.changed
+
+        - name: Wait for controlplane to complete reconciliation
+          environment:
+            KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}"
+            PATH: "{{ cifmw_path }}"
+          ansible.builtin.shell: |
+            set -xe -o pipefail
+            oc -n {{ namespace }} wait {{ _ctlplane_name.stdout }} --for condition=Ready --timeout=10m
+          when: _glance_ini_file.changed