[multiple] Co-locate provisionserver with metal3 to prevent DHCP failures

When metal3-dnsmasq pod restarts during a node's DHCP lease renewal on the
provisioning network (172.23.0.0/24), NetworkManager fails to renew and sets
ipv4.method=disabled. NMState operator then preserves this disabled state,
causing permanent loss of provisioning network connectivity on that node.

The issue occurs when OpenStackProvisionServer and metal3 pods run on
different nodes. If metal3 restarts while a node is attempting DHCP renewal,
the temporary unavailability of metal3-dnsmasq causes the renewal to fail.

Solution:
Automatically detect the node running metal3 pod (via k8s-app=metal3 label)
and configure provisionServerNodeSelector in baremetalSetTemplate to schedule
OpenStackProvisionServer on the same node. This ensures provisioning network
connectivity is maintained because metal3-static-ip-manager maintains a static
IP (172.23.0.3) on the metal3 node regardless of dnsmasq restarts.

Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: mnietoji

roles/ci_gen_kustomize_values/templates/nfv-ovs-dpdk-sriov-hci/edpm-nodeset-values/values.yaml.j2

@@ -43,3 +43,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_baremetal_hosts is defined and
+      cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/ovs-dpdk-sriov-2nodesets/edpm-nodeset-values/values.yaml.j2

@@ -56,3 +56,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_baremetal_hosts is defined and
+      cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/ovs-dpdk-sriov-ipv6-2nodesets/edpm-nodeset-values/values.yaml.j2

@@ -56,3 +56,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_baremetal_hosts is defined and
+      cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/ovs-dpdk-sriov-ipv6/edpm-nodeset-values/values.yaml.j2

@@ -43,3 +43,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_baremetal_hosts is defined and
+      cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/ovs-dpdk-sriov/edpm-nodeset-values/values.yaml.j2

@@ -43,3 +43,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_baremetal_hosts is defined and
+      cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/ovs-dpdk/edpm-nodeset-values/values.yaml.j2

@@ -42,3 +42,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_baremetal_hosts is defined and
+      cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/sriov/edpm-nodeset-values/values.yaml.j2

@@ -42,3 +42,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_baremetal_hosts is defined and
+      cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/kustomize_deploy/tasks/execute_step.yml

@@ -126,6 +126,33 @@
       ansible.builtin.include_role:
         name: run_hook
 
+    - name: Detect metal3 pod node for baremetal nodeset provisioning
+      when:
+        - stage.name is defined
+        - stage.name is match('edpm-nodeset.*')
+      block:
+        - name: Get metal3 pod information
+          kubernetes.core.k8s_info:
+            kubeconfig: "{{ cifmw_openshift_kubeconfig }}"
+            kind: Pod
+            namespace: openshift-machine-api
+            label_selectors:
+              - k8s-app=metal3
+          register: _cifmw_kustomize_deploy_metal3_pod_info
+
+        - name: Set metal3 node for provisionserver nodeSelector
+          ansible.builtin.set_fact:
+            cifmw_kustomize_deploy_metal3_node: "{{ _cifmw_kustomize_deploy_metal3_pod_info.resources[0].spec.nodeName }}"
+            cacheable: false
+          when:
+            - _cifmw_kustomize_deploy_metal3_pod_info.resources is defined
+            - _cifmw_kustomize_deploy_metal3_pod_info.resources | length > 0
+
+        - name: Log metal3 node location
+          ansible.builtin.debug:
+            msg: "Metal3 pod is running on {{ cifmw_kustomize_deploy_metal3_node }}, provisionserver will be co-located there"
+          when: cifmw_kustomize_deploy_metal3_node is defined
+
     - name: "Generate values.yaml for {{ stage.path }}"
       when:
         - _val.src_file is defined