[manila_create_default_resources] Fix extra_specs string vs dict handling

When extra_specs is passed via extra_vars on the command line
(e.g. -e 'extra_specs={}'), Ansible receives it as a string instead
of a dict. The original task-level vars: block evaluated
extra_specs.items() before the when: condition was checked, causing
the play to fail with 'str object has no attribute items'.

Split into a set_fact task guarded by 'extra_specs is mapping' and a
separate command task guarded by 'extra_spec_opt is defined' to handle
both dict and string inputs safely.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: lkuchlan <lkuchlan@redhat.com>

Author: lkuchlan

hooks/playbooks/manila_create_default_resources.yml

@@ -21,14 +21,17 @@
         ( ( _manila_share_creation.rc | int ) != 0 )
         and not ( "HTTP 409" in _manila_share_creation.stderr )
 
+    - name: Prepare extra spec options string
+      when: extra_specs is mapping and extra_specs | length > 0
+      ansible.builtin.set_fact:
+        # convert dict to 'k=v ...' format; guard against extra_specs being passed as a string
+        extra_spec_opt: "{%- for k, v in extra_specs.items() -%}{{ k }}={{ v }} {% endfor -%}"
+
     - name: Update default share type properties
+      when: extra_spec_opt is defined
       environment:
         KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}"
         PATH: "{{ cifmw_path }}"
-      vars:
-        # convert dict to 'k=v ...' format
-        extra_spec_opt: "{%- for k, v in extra_specs.items() -%}{{ k }}={{ v }} {% endfor -%}"
-      when: extra_spec_opt | length > 0
       ansible.builtin.command: |
         oc -n {{ namespace }} exec -it pod/openstackclient \
           -- openstack share type set {{ share_type_name }} --extra-specs {{ extra_spec_opt }}