Fix ansible 2.19 jinja incompatibility#3168
Conversation
Signed-off-by: rabi <ramishra@redhat.com>
Depends-On: openstack-k8s-operators/openstack-operator#1547 Depends-On: openstack-k8s-operators/ci-framework#3168 Signed-off-by: rabi <ramishra@redhat.com>
Depends-On: openstack-k8s-operators/openstack-operator#1547 Depends-On: openstack-k8s-operators/ci-framework#3168 Signed-off-by: rabi <ramishra@redhat.com>
Non boolean conditionals are not allowed in ansible 2.19. Fix private var access from namespace not allowed Depends-On: openstack-k8s-operators/openstack-operator#1547 Depends-On: openstack-k8s-operators/ci-framework#3168 Signed-off-by: rabi <ramishra@redhat.com>
Non boolean conditionals are not allowed in ansible 2.19. Fix private var access from namespace not allowed Depends-On: openstack-k8s-operators/openstack-operator#1547 Depends-On: openstack-k8s-operators/ci-framework#3168 Signed-off-by: rabi <ramishra@redhat.com>
Non boolean conditionals are not allowed in ansible 2.19. Fix private var access from namespace not allowed Depends-On: openstack-k8s-operators/openstack-operator#1547 Depends-On: openstack-k8s-operators/ci-framework#3168 Signed-off-by: rabi <ramishra@redhat.com>
|
We need to merge this, as openstack-k8s-operators/edpm-ansible#993 has already merged. |
danpawlik
left a comment
There was a problem hiding this comment.
I don't like the commit message, but I can live with that.
Linked jira has the details. Anyway, I've updated it now. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jokke-ilujo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Probably it would fix error: |
Update jinja2 template to work with ansible 2.19 Corresponding cifmw fix: openstack-k8s-operators/ci-framework#3168. Reviewed-by: Rabi Mishra <ramishra@redhat.com> Reviewed-by: John Fulton <johfulto@redhat.com>
|
/cherry-pick 18.0-fr3 |
|
@tosky: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Ups, please ignore this, I just wanted to backport a similar change in another repository and used the wrong browser window. |
With ansible 2.19 it prints the return value of the mtu_list.append() as None and the network config is not parseable with os-net-config and it fails with,
os_net_config.main No interfaces defined in config: /etc/os-net-config/config.yaml"]}
jira: OSPRH-18609