Skip to content

[OSPCIX-1017] Add custom network-values template for HCI adoption scenario#3189

Merged
sdatko merged 1 commit into
openstack-k8s-operators:mainfrom
abays:OSPCIX-1017
Aug 12, 2025
Merged

[OSPCIX-1017] Add custom network-values template for HCI adoption scenario#3189
sdatko merged 1 commit into
openstack-k8s-operators:mainfrom
abays:OSPCIX-1017

Conversation

@abays

@abays abays commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

The HCI adoption (uni03gamma) job needs to use the same network-values template as the regular uni03gamma job does.

Fixes: https://issues.redhat.com/browse/OSPCIX-1017

@abays abays requested a review from a team as a code owner August 11, 2025 16:15
@openshift-ci

openshift-ci Bot commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9866d23149cf4416b302441d98e4ff9b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 57s
podified-multinode-edpm-deployment-crc FAILURE in 1h 32m 42s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 50m 00s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 36s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 4m 31s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 52s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 04s
✔️ build-push-container-cifmw-client SUCCESS in 20m 53s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 31s

@ciecierski

Copy link
Copy Markdown
Contributor

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d89de52453804f00baeeea400dbbf183

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 36s
podified-multinode-edpm-deployment-crc FAILURE in 1h 34m 05s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 27m 24s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 01s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 4m 30s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 17s
✔️ cifmw-architecture-validate-hci SUCCESS in 5m 32s
✔️ build-push-container-cifmw-client SUCCESS in 19m 51s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 53s

@sdatko sdatko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succeeded in testproject ❤️

@sdatko

sdatko commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

recheck

@sdatko sdatko enabled auto-merge (rebase) August 11, 2025 21:47
@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/74e3a709723b4cbb82c3d7fa2130b677

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 37s
podified-multinode-edpm-deployment-crc FAILURE in 1h 32m 33s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 34m 26s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 44s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 4m 45s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 42s
✔️ cifmw-architecture-validate-hci SUCCESS in 6m 20s
✔️ build-push-container-cifmw-client SUCCESS in 20m 05s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 22s

@jirimacku

Copy link
Copy Markdown
Contributor

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/17a08671a58a400bab211bb9ff57c42c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 14s
podified-multinode-edpm-deployment-crc FAILURE in 1h 32m 20s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 30s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 48s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 4m 40s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 17s
✔️ cifmw-architecture-validate-hci SUCCESS in 3m 57s
✔️ build-push-container-cifmw-client SUCCESS in 15m 49s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 11s

@amartyasinha

Copy link
Copy Markdown
Contributor

recheck

@danpawlik

Copy link
Copy Markdown
Contributor

Change #3168 was merged, this time should be ok.

@sdatko sdatko merged commit dcc9388 into openstack-k8s-operators:main Aug 12, 2025
4 checks passed
@tosky

tosky commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

Just a small request for future patches: please ensure that important comments like

The HCI adoption (uni03gamma) job needs to use the same network-values template as the regular uni03gamma job does.

are part of the commits and not just of the pull request, otherwise they are not available when checking the repository.

@abays

abays commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

Just a small request for future patches: please ensure that important comments like

The HCI adoption (uni03gamma) job needs to use the same network-values template as the regular uni03gamma job does.

are part of the commits and not just of the pull request, otherwise they are not available when checking the repository.

In this case, the actual commit message is more important and accurate than that comment. Hence it was written as-is. But your point is otherwise well-taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants