[DNM] [update] Restrict post-services split update tests to tempest only#3979
Draft
Valkyrie00 wants to merge 1 commit into
Draft
[DNM] [update] Restrict post-services split update tests to tempest only#3979Valkyrie00 wants to merge 1 commit into
Valkyrie00 wants to merge 1 commit into
Conversation
During a split update, the continuous control plane check runs in the background creating and deleting VMs in a loop. When tobiko tests run in the intermediate post-services test stage, they may encounter these transient VMs in BUILD state, causing non-deterministic failures (HTTP 409 Conflict / HTTP 404). Override cifmw_test_operator_stages in the post-services test task to run only tempest, excluding tobiko from the intermediate stage. Tobiko continues to run in the final post-update test stage (in update-edpm.yml), after the control plane check has been stopped. Closes: OSPCIX-1381 Signed-off-by: Vito Castellano <vcastell@redhat.com>
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During a split update (
cifmw_update_variant: split), the "Run tests after Services update" task inupdate_variant_split.ymlruns the fullcifmw_test_operator_stages(tobiko + tempest) while the continuous controlplane check is still active in the background.
The control plane check continuously creates and deletes VMs, which can collide with tobiko's
action_on_all_instances('active')call, causing non-deterministic failures when tobiko encounters VMs inBUILDstate.This PR overrides
cifmw_test_operator_stagesin the intermediate post-services test task to only include tempest. Tobiko continues to run as before in the final post-update stage (update-edpm.yml), where the control plane check has already been stopped.Context
This is an alternative approach to #3978, which stops and restarts the control plane check around the intermediate tests. This approach was suggested during review as a cleaner solution that preserves uninterrupted control plane monitoring throughout the entire update.
Closes: OSPCIX-1381
Assisted-By: Cursor