Skip to content

[openshift_setup] Add catalog registry auth and signature policy bypass#4068

Open
rebtoor wants to merge 1 commit into
openstack-k8s-operators:stablefrom
rebtoor:DNM-OSPCIX-1431-catalog-source
Open

[openshift_setup] Add catalog registry auth and signature policy bypass#4068
rebtoor wants to merge 1 commit into
openstack-k8s-operators:stablefrom
rebtoor:DNM-OSPCIX-1431-catalog-source

Conversation

@rebtoor

@rebtoor rebtoor commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

When cifmw_openshift_setup_catalog_registry_credentials is defined:

  • Merge the auth into the cluster openshift-config/pull-secret so nodes can pull from the Konflux image-rbac-proxy registry.
  • Add the catalog registry to insecureRegistries and allowedRegistries to bypass image signature validation for Konflux-built FBC catalogs.
  • Wait for MachineConfigPools to settle after IDMS + pull-secret changes before proceeding.

All three actions are gated on cifmw_openshift_setup_catalog_registry_credentials — jobs that don't set it are completely unaffected.

Context

Architecture-update jobs on OCP 4.18 need openstack-operator.v1.0.7 from a Konflux FBC catalog behind image-rbac-proxy. The cluster needs pull-secret credentials AND signature policy bypass for that registry before the CatalogSource pod can pull.

Related-Issue: #OSPCIX-1431

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rebtoor
rebtoor force-pushed the DNM-OSPCIX-1431-catalog-source branch 3 times, most recently from c740eb5 to 057ee3b Compare July 20, 2026 20:06
@rebtoor rebtoor changed the title DNM: Apply CatalogSource from content-set catalog manifest [openshift_setup] Apply CatalogSource from content-set catalog manifest Jul 20, 2026
@rebtoor
rebtoor marked this pull request as ready for review July 20, 2026 20:08
evallesp
evallesp previously approved these changes Jul 21, 2026

@evallesp evallesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 21, 2026
@rebtoor
rebtoor force-pushed the DNM-OSPCIX-1431-catalog-source branch from 057ee3b to 6043778 Compare July 21, 2026 12:17
@openshift-ci openshift-ci Bot removed the lgtm label Jul 21, 2026
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from evallesp. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rebtoor
rebtoor requested a review from evallesp July 21, 2026 12:19
@rebtoor
rebtoor force-pushed the DNM-OSPCIX-1431-catalog-source branch from 6043778 to f2ab043 Compare July 21, 2026 21:57
@rebtoor
rebtoor force-pushed the DNM-OSPCIX-1431-catalog-source branch from f2ab043 to cae6b5b Compare July 21, 2026 21:59
@rebtoor rebtoor changed the title [openshift_setup] Apply CatalogSource from content-set catalog manifest [openshift_setup] Merge catalog registry credentials and wait for MCP Jul 21, 2026
@rebtoor
rebtoor force-pushed the DNM-OSPCIX-1431-catalog-source branch from cae6b5b to 9fc3709 Compare July 22, 2026 06:58
evallesp
evallesp previously approved these changes Jul 22, 2026

@evallesp evallesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rebtoor
rebtoor force-pushed the DNM-OSPCIX-1431-catalog-source branch from 9fc3709 to d5d286b Compare July 22, 2026 21:14
@openshift-ci openshift-ci Bot removed the lgtm label Jul 22, 2026
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@rebtoor
rebtoor force-pushed the DNM-OSPCIX-1431-catalog-source branch from d5d286b to 362061c Compare July 22, 2026 21:16
@rebtoor rebtoor changed the title [openshift_setup] Merge catalog registry credentials and wait for MCP [openshift_setup] Add catalog registry auth and signature policy bypass Jul 22, 2026
When cifmw_openshift_setup_catalog_registry_credentials is defined:
- Merge the auth into the cluster pull-secret so nodes can pull from
  the Konflux image-rbac-proxy registry.
- Add the catalog registry to insecure and allowed registries to
  bypass image signature validation for Konflux-built FBC catalogs.
- Wait for MachineConfigPools to settle after IDMS + pull-secret
  changes before proceeding.

Related-Issue: #OSPCIX-1431
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebtoor
rebtoor force-pushed the DNM-OSPCIX-1431-catalog-source branch from 362061c to 5be28f2 Compare July 22, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants