Upgrade to Operator SDK 1.41.1 by stuggi · Pull Request #571 · openstack-k8s-operators/cinder-operator

stuggi · 2025-11-13T11:49:16Z

This commit upgrades the cinder-operator to use Operator SDK version 1.41.1, with the following major changes:

Project Structure:

Move pkg/ packages to internal/ following Go best practices
Move controllers/ to internal/controller/ per new operator-sdk layout
Replace main.go with cmd/main.go
Add controller and webhook test suites

Configuration Updates:

Split certificate management into separate metrics and webhook certs
Add network policies for metrics and webhook traffic
Rename auth_proxy resources to metrics for clarity
Add admin RBAC roles for all CRD types (Cinder, CinderAPI, etc.)
Update manager deployment configuration and patches
Modernize kustomization configurations

Webhook Changes:

Add dedicated webhook implementation in internal/webhook/v1beta1/
Remove old CRD webhook and CA injection patches
Update webhook manifests and service configuration

Cleanup:

Remove obsolete config patches and overlays

Dependencies:

Update go.mod and go.sum for operator-sdk 1.41.1 dependencies

Jira: OSPRH-21923

Assisted-by: claude-4-sonnet

Depends-On: openstack-k8s-operators/openstack-operator#1683

softwarefactory-project-zuul · 2025-11-13T11:49:24Z

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/cinder-operator on branch main. The
problem was:

mapping values are not allowed in this context
in "openstack-k8s-operators/cinder-operator/zuul.d/projects.yaml@main", line 7, column 17

softwarefactory-project-zuul · 2025-11-13T12:20:52Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e823f713a40b42f2b15dc5f60afabfb3

❌ openstack-k8s-operators-content-provider FAILURE in 12m 07s
⚠️ cinder-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ cinder-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

softwarefactory-project-zuul · 2025-11-13T13:59:03Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1683 is needed.

stuggi · 2025-11-13T14:02:20Z

recheck

softwarefactory-project-zuul · 2025-11-13T14:18:03Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/18abf0d0bbf840f495734eba4fac2d36

❌ openstack-k8s-operators-content-provider FAILURE in 14m 27s
⚠️ cinder-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ cinder-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

stuggi · 2025-11-13T15:04:37Z

recheck

softwarefactory-project-zuul · 2025-11-13T15:58:48Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/install_yamls#1110 is needed.

stuggi · 2025-11-13T15:59:05Z

/retest

stuggi · 2025-11-13T16:00:16Z

recheck

softwarefactory-project-zuul · 2025-11-13T17:29:45Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1683 is needed.

stuggi · 2025-11-14T05:58:52Z

/retest

stuggi · 2025-11-14T08:35:35Z

recheck

softwarefactory-project-zuul · 2025-11-14T16:00:09Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1683 is needed.

stuggi · 2025-11-14T16:02:37Z

recheck

stuggi · 2025-11-17T08:40:27Z

/retest

stuggi · 2025-11-17T09:16:51Z

/retest

softwarefactory-project-zuul · 2025-11-17T10:40:29Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 1683,19db487cf23204e39d5f67be71ad37d8a1632c92

stuggi · 2025-11-17T13:29:26Z

recheck

stuggi · 2025-11-17T13:29:31Z

/retest

stuggi · 2025-11-17T20:45:37Z

/retest

stuggi · 2025-11-18T06:31:41Z

/retest

stuggi · 2025-11-18T10:44:07Z

/retest

stuggi · 2025-11-19T06:49:13Z

/retest

stuggi · 2025-11-19T14:27:26Z

/retest

This commit upgrades the cinder-operator to use Operator SDK version 1.41.1, with the following major changes: Project Structure: - Move pkg/ packages to internal/ following Go best practices - Move controllers/ to internal/controller/ per new operator-sdk layout - Replace main.go with cmd/main.go - Add controller and webhook test suites Configuration Updates: - Split certificate management into separate metrics and webhook certs - Add network policies for metrics and webhook traffic - Rename auth_proxy resources to metrics for clarity - Add admin RBAC roles for all CRD types (Cinder, CinderAPI, etc.) - Update manager deployment configuration and patches - Modernize kustomization configurations Webhook Changes: - Add dedicated webhook implementation in internal/webhook/v1beta1/ - Remove old CRD webhook and CA injection patches - Update webhook manifests and service configuration Cleanup: - Remove obsolete config patches and overlays Dependencies: - Update go.mod and go.sum for operator-sdk 1.41.1 dependencies Jira: OSPRH-21923 Assisted-by: claude-4-sonnet Signed-off-by: Martin Schuppert <mschuppert@redhat.com>

softwarefactory-project-zuul · 2025-11-20T11:11:37Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c115ea2b89ca48589487ed5203fbf1b3

❌ openstack-k8s-operators-content-provider TIMED_OUT in 31m 09s
⚠️ cinder-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ cinder-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

stuggi · 2025-11-20T15:48:52Z

recheck

softwarefactory-project-zuul · 2025-11-20T16:59:46Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1683 is needed.

stuggi · 2025-11-21T13:07:14Z

recheck

abays

/lgtm

openshift-ci · 2025-11-24T19:52:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [abays,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stuggi added the do-not-merge/hold label Nov 13, 2025

openshift-ci Bot requested review from ASBishop and viroel November 13, 2025 11:49

openshift-ci Bot added the approved label Nov 13, 2025

stuggi force-pushed the operator_sdk_1.41.1 branch 3 times, most recently from 146d8ca to caffbde Compare November 13, 2025 12:07

stuggi force-pushed the operator_sdk_1.41.1 branch from caffbde to edf7b4b Compare November 13, 2025 13:51

stuggi force-pushed the operator_sdk_1.41.1 branch from edf7b4b to 7ee1996 Compare November 13, 2025 15:21

stuggi force-pushed the operator_sdk_1.41.1 branch 2 times, most recently from 4611390 to 76e0694 Compare November 14, 2025 11:44

dprince reviewed Nov 14, 2025

View reviewed changes

Comment thread zuul.d/jobs.yaml Outdated

dprince reviewed Nov 14, 2025

View reviewed changes

Comment thread zuul.d/jobs.yaml Outdated

stuggi force-pushed the operator_sdk_1.41.1 branch 4 times, most recently from eb16018 to d956863 Compare November 14, 2025 15:02

stuggi force-pushed the operator_sdk_1.41.1 branch from d956863 to eccfd19 Compare November 17, 2025 07:42

stuggi force-pushed the operator_sdk_1.41.1 branch from eccfd19 to 7fb88a7 Compare November 17, 2025 10:40

stuggi force-pushed the operator_sdk_1.41.1 branch from 7fb88a7 to 5c079ca Compare November 20, 2025 10:39

stuggi removed the do-not-merge/hold label Nov 24, 2025

abays approved these changes Nov 24, 2025

View reviewed changes

openshift-ci Bot assigned abays Nov 24, 2025

openshift-ci Bot added the lgtm label Nov 24, 2025

openshift-merge-bot Bot merged commit 3091dc4 into openstack-k8s-operators:main Nov 24, 2025
8 checks passed

Uh oh!

Conversation

stuggi commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

softwarefactory-project-zuul Bot commented Nov 13, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Nov 13, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Nov 13, 2025

Uh oh!

stuggi commented Nov 13, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Nov 13, 2025

Uh oh!

stuggi commented Nov 13, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Nov 13, 2025

Uh oh!

stuggi commented Nov 13, 2025

Uh oh!

stuggi commented Nov 13, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Nov 13, 2025

Uh oh!

stuggi commented Nov 14, 2025

Uh oh!

stuggi commented Nov 14, 2025

Uh oh!

Uh oh!

Uh oh!

softwarefactory-project-zuul Bot commented Nov 14, 2025

Uh oh!

stuggi commented Nov 14, 2025

Uh oh!

stuggi commented Nov 17, 2025

Uh oh!

stuggi commented Nov 17, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Nov 17, 2025

Uh oh!

stuggi commented Nov 17, 2025

Uh oh!

stuggi commented Nov 17, 2025

Uh oh!

stuggi commented Nov 17, 2025

Uh oh!

stuggi commented Nov 18, 2025

Uh oh!

stuggi commented Nov 18, 2025

Uh oh!

stuggi commented Nov 19, 2025

Uh oh!

stuggi commented Nov 19, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Nov 20, 2025

Uh oh!

stuggi commented Nov 20, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Nov 20, 2025

Uh oh!

stuggi commented Nov 21, 2025

Uh oh!

abays left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Nov 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stuggi commented Nov 13, 2025 •

edited

Loading