nova_verify, pre_launch_ironic: fix ironic post-adoption provisioning

The post-adoption ironic instance provisioning task in nova_verify.yaml
can fail with quota exceeded (HTTP 403) when the adopted environment
already uses all available instances (e.g. uni04delta-ipv6 with 10 VMs
from the source cloud at the default quota of 10).

Set the instance quota correctly from the start in pre_launch_ironic.bash
by reading the current quota and adding headroom for the pre-adoption
and post-adoption test instances. The quota carries over through the
Nova database migration during adoption, so the post-adoption
provisioning step no longer hits the limit.

Also add ironic_post_adoption_create_instance variable (default true)
to allow scenarios to skip the post-adoption provisioning step entirely.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: rebtoor

tests/roles/dataplane_adoption/tasks/nova_verify.yaml

@@ -58,6 +58,7 @@
   when:
     - prelaunch_test_instance|bool
     - "'pre_launch_ironic.bash' in prelaunch_test_instance_scripts"
+    - ironic_post_adoption_create_instance|bool
   ansible.builtin.shell: |
     {{ shell_header }}
     {{ oc_header }}

tests/roles/development_environment/files/pre_launch_ironic.bash

@@ -132,6 +132,10 @@ else
   echo "Found $ACTIVE_NODES active node(s), skipping node management operations"
 fi
 
+# Ensure quota has headroom for pre-adoption and post-adoption test instances
+CURRENT_QUOTA=$(${BASH_ALIASES[openstack]} quota show -c instances -f value)
+${BASH_ALIASES[openstack]} quota set --instances $((CURRENT_QUOTA + 2)) default
+
 # Create test instance on baremetal
 if [[ "${PRE_LAUNCH_IRONIC_CREATE_INSTANCE,,}" != "false" ]]; then
   # Wait for nova to be aware of the node

tests/roles/ironic_adoption/defaults/main.yaml

@@ -109,3 +109,4 @@ ironic_retry_delay: 5
 ironic_post_adoption_manage_nodes: false
 ironic_post_adoption_inspect_nodes: false
 ironic_post_adoption_provide_nodes: false
+ironic_post_adoption_create_instance: true