Fix yaml linting issue

Co-Authored-By: John Fulton <fulton@redhat.com>

Signed-off-by: Oliver Walsh <owalsh@redhat.com>

Author: olliewalsh

scenarios/dcn_nostorage/central/config_download.yaml

@@ -92,14 +92,14 @@ parameter_defaults:
   ComputeNetworkConfigTemplate: /home/stack/central/network/spine-leaf-nics/compute0.j2
   ComputeParameters:
     NeutronBridgeMappings:
-    - leaf0:br-ex
+      - leaf0:br-ex
   ControllerNetworkConfigTemplate: /home/stack/central/network/spine-leaf-nics/controller0.j2
   ControllerParameters:
     NeutronBridgeMappings:
-    - leaf0:br-ex
+      - leaf0:br-ex
   DnsServers:
-  - 10.11.5.19
-  - 10.5.30.160
+    - 10.11.5.19
+    - 10.5.30.160
   NeutronEnableDVR: 'false'
   NeutronFlatNetworks: leaf0,leaf1,leaf2
   NeutronNetworkType: geneve
@@ -108,8 +108,8 @@ parameter_defaults:
   NovaComputeAvailabilityZone: az-central
   NovaCrossAZAttach: false
   NtpServer:
-  - clock.redhat.com
-  - clock2.redhat.com
+    - clock.redhat.com
+    - clock2.redhat.com
   PythonInterpreter: /usr/bin/python3
   RootStackName: central
   VipSubnetMap:

scenarios/dcn_nostorage/central/roles.yaml

@@ -31,7 +31,7 @@
     OVNCMSOptions: "enable-chassis-as-gw"
   # Deprecated & backward-compatible values (FIXME: Make parameters consistent)
   # Set uses_deprecated_params to True if any deprecated params are used.
-  uses_deprecated_params: True
+  uses_deprecated_params: true
   deprecated_param_extraconfig: 'controllerExtraConfig'
   deprecated_param_flavor: 'OvercloudControlFlavor'
   deprecated_param_image: 'controllerImage'
@@ -207,7 +207,7 @@
   # Set uses_deprecated_params to True if any deprecated params are used.
   # These deprecated_params only need to be used for existing roles and not for
   # composable roles.
-  uses_deprecated_params: True
+  uses_deprecated_params: true
   deprecated_param_image: 'NovaImage'
   deprecated_param_extraconfig: 'NovaComputeExtraConfig'
   deprecated_param_metadata: 'NovaComputeServerMetadata'
@@ -261,4 +261,4 @@
     - OS::TripleO::Services::Tuned
     - OS::TripleO::Services::Vpp
     - OS::TripleO::Services::OVNController
-    - OS::TripleO::Services::OVNMetadataAgent
+    - OS::TripleO::Services::OVNMetadataAgent

scenarios/dcn_nostorage/dcn1/config_download.yaml

@@ -45,6 +45,7 @@ parameter_defaults:
   ControllerExtraConfig:
     nova::compute::libvirt::services::libvirt_virt_type: qemu
     nova::compute::libvirt::virt_type: qemu
+    nova::availability_zone::default_schedule_zone: az-central
   ComputeDcn1ExtraConfig:
     nova::compute::libvirt::services::libvirt_virt_type: qemu
     nova::compute::libvirt::virt_type: qemu
@@ -101,9 +102,6 @@ parameter_defaults:
         name: leaf2
         ip_version: 4
 
-  BondInterfaceOvsOptions: bond_mode=active-backup
-  ControllerExtraConfig:
-    nova::availability_zone::default_schedule_zone: az-central
   VipSubnetMap:
     ctlplane: leaf1
   NeutronFlatNetworks: leaf0,leaf1,leaf2
@@ -113,12 +111,12 @@ parameter_defaults:
     NeutronBridgeMappings: ["leaf1:br-ex"]
   PythonInterpreter: /usr/bin/python3
   DnsServers: ['10.11.5.19', '10.5.30.160']
-  NtpServer: ["clock.redhat.com","clock2.redhat.com"]
+  NtpServer: ["clock.redhat.com", "clock2.redhat.com"]
   NovaComputeAvailabilityZone: az-dcn1
-  NovaCrossAZAttach: False
+  NovaCrossAZAttach: false
   RootStackName: dcn1
   AuthCloudName: 'central'
-  ManageNetworks: False
+  ManageNetworks: false
 
   NeutronNetworkType: geneve
   NeutronTunnelTypes: geneve

scenarios/dcn_nostorage/dcn1/roles.yaml

@@ -25,7 +25,7 @@
   # Set uses_deprecated_params to True if any deprecated params are used.
   # These deprecated_params only need to be used for existing roles and not for
   # composable roles.
-  uses_deprecated_params: True
+  uses_deprecated_params: true
   deprecated_param_image: 'NovaImage'
   deprecated_param_extraconfig: 'NovaComputeExtraConfig'
   deprecated_param_metadata: 'NovaComputeServerMetadata'
@@ -79,4 +79,4 @@
     - OS::TripleO::Services::Tuned
     - OS::TripleO::Services::Vpp
     - OS::TripleO::Services::OVNController
-    - OS::TripleO::Services::OVNMetadataAgent
+    - OS::TripleO::Services::OVNMetadataAgent

scenarios/dcn_nostorage/dcn1/vips_data.yaml

@@ -13,4 +13,4 @@
   subnet: storage_leaf1
 - network: storage_mgmt
   dns_name: overcloud
-  subnet: storage_mgmt_leaf1
+  subnet: storage_mgmt_leaf1

scenarios/dcn_nostorage/dcn2/config_download.yaml

@@ -45,6 +45,7 @@ parameter_defaults:
   ControllerExtraConfig:
     nova::compute::libvirt::services::libvirt_virt_type: qemu
     nova::compute::libvirt::virt_type: qemu
+    nova::availability_zone::default_schedule_zone: az-central
   ComputeDcn2ExtraConfig:
     nova::compute::libvirt::services::libvirt_virt_type: qemu
     nova::compute::libvirt::virt_type: qemu
@@ -101,9 +102,6 @@ parameter_defaults:
         name: leaf2
         ip_version: 4
 
-  BondInterfaceOvsOptions: bond_mode=active-backup
-  ControllerExtraConfig:
-    nova::availability_zone::default_schedule_zone: az-central
   VipSubnetMap:
     ctlplane: leaf2
   NeutronFlatNetworks: leaf0,leaf1,leaf2
@@ -113,12 +111,12 @@ parameter_defaults:
     NeutronBridgeMappings: ["leaf2:br-ex"]
   PythonInterpreter: /usr/bin/python3
   DnsServers: ['10.11.5.19', '10.5.30.160']
-  NtpServer: ["clock.redhat.com","clock2.redhat.com"]
+  NtpServer: ["clock.redhat.com", "clock2.redhat.com"]
   NovaComputeAvailabilityZone: az-dcn2
-  NovaCrossAZAttach: False
+  NovaCrossAZAttach: false
   RootStackName: dcn2
   AuthCloudName: 'central'
-  ManageNetworks: False
+  ManageNetworks: false
 
   NeutronNetworkType: geneve
   NeutronTunnelTypes: geneve

scenarios/dcn_nostorage/dcn2/roles.yaml

@@ -25,7 +25,7 @@
   # Set uses_deprecated_params to True if any deprecated params are used.
   # These deprecated_params only need to be used for existing roles and not for
   # composable roles.
-  uses_deprecated_params: True
+  uses_deprecated_params: true
   deprecated_param_image: 'NovaImage'
   deprecated_param_extraconfig: 'NovaComputeExtraConfig'
   deprecated_param_metadata: 'NovaComputeServerMetadata'