Skip barbican_adoption role when barbican is not enabled

The barbican_adoption role runs unconditionally in all test playbooks,
even when Barbican is not deployed on the source TripleO standalone.
The KEK extraction fails with a KeyError and silently writes an empty
BarbicanSimpleCryptoKEK to osp-secret. The barbican-operator then
rejects the empty value with "empty password not allowed" (validation
introduced by lib-common PR #672), and the job times out waiting for
Barbican pods that are never created.

Gate the barbican_adoption role on prelaunch_barbican_secret, which is
already written to vars.yaml by the deploy playbook with the value of
enable_barbican. This is consistent with how tls_adoption and
telemetry_adoption are already gated on variables present in vars.yaml.

Signed-off-by: Mauricio Harley <mharley@redhat.com>

Author: Mauricio Harley

tests/playbooks/test_minimal.yaml

@@ -36,7 +36,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
-      when: enable_barbican|default(true)|bool
+      when: prelaunch_barbican_secret | default(false) | bool
     - role: neutron_adoption
       tags:
         - neutron_adoption

tests/playbooks/test_rollback_minimal.yaml

@@ -37,7 +37,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
-      when: enable_barbican|default(true)|bool
+      when: prelaunch_barbican_secret | default(false) | bool
     - role: neutron_adoption
       tags:
         - neutron_adoption

tests/playbooks/test_rollback_with_ceph.yaml

@@ -45,7 +45,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
-      when: enable_barbican|default(true)|bool
+      when: prelaunch_barbican_secret | default(false) | bool
     - role: neutron_adoption
       tags:
         - neutron_adoption

tests/playbooks/test_with_ceph.yaml

@@ -45,7 +45,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
-      when: enable_barbican|default(true)|bool
+      when: prelaunch_barbican_secret | default(false) | bool
     - role: neutron_adoption
       tags:
         - neutron_adoption

tests/playbooks/test_with_ceph_and_ironic.yaml

@@ -69,7 +69,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
-      when: enable_barbican|default(true)|bool
+      when: prelaunch_barbican_secret | default(false) | bool
     - role: neutron_adoption
       tags:
         - neutron_adoption

tests/playbooks/test_with_ironic.yaml

@@ -57,7 +57,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
-      when: enable_barbican|default(true)|bool
+      when: prelaunch_barbican_secret | default(false) | bool
     - role: neutron_adoption
       tags:
         - neutron_adoption

tests/roles/barbican_adoption/tasks/main.yaml

@@ -91,7 +91,6 @@
   delay: "{{ barbican_retry_delay }}"
 
 - name: check that Barbican secret payload was migrated successfully
-  when: prelaunch_barbican_secret|default(false)
   ansible.builtin.shell: |
     {{ shell_header }}
     {{ oc_header }}