Skip barbican_adoption role when barbican is not enabled

Mauricio Harley · Mauricio Harley · commit ebf7e7447f0c · 2026-03-08T19:25:18.000Z
The barbican_adoption role runs unconditionally in all test playbooks, even when enable_barbican is set to false. When Barbican is not deployed on the source TripleO standalone, the KEK extraction fails with a KeyError and silently writes an empty BarbicanSimpleCryptoKEK to osp-secret. The barbican-operator then rejects the empty value with "empty password not allowed" (validation introduced by lib-common PR #672), and the job times out waiting for Barbican pods that are never created. Gate the barbican_adoption role on enable_barbican|default(true)|bool in all six test playbooks, consistent with how tls_adoption and telemetry_adoption are already gated. Signed-off-by: Mauricio Harley <mharley@redhat.com>
diff --git a/tests/playbooks/test_minimal.yaml b/tests/playbooks/test_minimal.yaml
@@ -36,6 +36,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
+      when: enable_barbican|default(true)|bool
     - role: neutron_adoption
       tags:
         - neutron_adoption
diff --git a/tests/playbooks/test_rollback_minimal.yaml b/tests/playbooks/test_rollback_minimal.yaml
@@ -37,6 +37,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
+      when: enable_barbican|default(true)|bool
     - role: neutron_adoption
       tags:
         - neutron_adoption
diff --git a/tests/playbooks/test_rollback_with_ceph.yaml b/tests/playbooks/test_rollback_with_ceph.yaml
@@ -45,6 +45,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
+      when: enable_barbican|default(true)|bool
     - role: neutron_adoption
       tags:
         - neutron_adoption
diff --git a/tests/playbooks/test_with_ceph.yaml b/tests/playbooks/test_with_ceph.yaml
@@ -45,6 +45,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
+      when: enable_barbican|default(true)|bool
     - role: neutron_adoption
       tags:
         - neutron_adoption
diff --git a/tests/playbooks/test_with_ceph_and_ironic.yaml b/tests/playbooks/test_with_ceph_and_ironic.yaml
@@ -69,6 +69,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
+      when: enable_barbican|default(true)|bool
     - role: neutron_adoption
       tags:
         - neutron_adoption
diff --git a/tests/playbooks/test_with_ironic.yaml b/tests/playbooks/test_with_ironic.yaml
@@ -57,6 +57,7 @@
     - role: barbican_adoption
       tags:
         - barbican_adoption
+      when: enable_barbican|default(true)|bool
     - role: neutron_adoption
       tags:
         - neutron_adoption
