Skip to content

edited Ceph DCN files - #1263

Closed
klgill wants to merge 1 commit into
openstack-k8s-operators:mainfrom
klgill:edit-dcn-docs
Closed

edited Ceph DCN files#1263
klgill wants to merge 1 commit into
openstack-k8s-operators:mainfrom
klgill:edit-dcn-docs

Conversation

@klgill

@klgill klgill commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

I edited the following files as part of @fultonj's PR (https://github.com/openstack-k8s-operators/data-plane-adoption/pull/1245/changes):

  • docs_user/modules/proc_adopting-compute-services-with-dcn-backend.adoc
  • docs_user/modules/proc_stopping-openstack-services.adoc

@openshift-ci

openshift-ci Bot commented Feb 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ciecierski for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@klgill
klgill requested a review from fultonj February 19, 2026 19:00
@fultonj

fultonj commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

@klgill

klgill commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

@fultonj Thank you! The diff LGTM. I haven't edited a PR like this, so I'm not sure what the next steps are. Would we merge both this PR and yours (1245)?

@fultonj

fultonj commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

@fultonj Thank you! The diff LGTM. I haven't edited a PR like this, so I'm not sure what the next steps are. Would we merge both this PR and yours (1245)?

OK, great! We should be able to just merge (1245) and it will have all of the changes already. It doesn't have any dependencies on this PR. If you're happy with what you see in the diff I linked, then you could close 1263.

@klgill klgill closed this Feb 25, 2026
@klgill

klgill commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

My changes were merged into #1245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fultonj fultonj Awaiting requested review from fultonj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@klgill @fultonj