Skip to content

fc-cinder-glance-with-cinder - #1287

Merged
openshift-merge-bot[bot] merged 2 commits into
openstack-k8s-operators:mainfrom
Jenny-Anne:OSPRH-23008-remove-cinder-fc-limitation
Mar 9, 2026
Merged

fc-cinder-glance-with-cinder#1287
openshift-merge-bot[bot] merged 2 commits into
openstack-k8s-operators:mainfrom
Jenny-Anne:OSPRH-23008-remove-cinder-fc-limitation

Conversation

@Jenny-Anne

@Jenny-Anne Jenny-Anne commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

https://issues.redhat.com/browse/OSPRH-23008

  • Removed FC from the adoption limitations file
  • Added bullet in the 'OpenShift preparation for Block Storage adoption' topic that the Image service must also run on hosts with HBAs when it's configured to use Block Storage with FC as a backend

@openshift-ci

openshift-ci Bot commented Mar 6, 2026

Copy link
Copy Markdown

Hi @Jenny-Anne. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Jenny-Anne
Jenny-Anne marked this pull request as draft March 6, 2026 10:52
tosky
tosky reviewed Mar 6, 2026
View reviewed changes
Comment thread docs_user/modules/con_adoption-limitations.adoc
tosky
tosky reviewed Mar 6, 2026
View reviewed changes

@tosky tosky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just a comment inline

@Jenny-Anne
Jenny-Anne marked this pull request as ready for review March 6, 2026 14:49
klgill
klgill reviewed Mar 6, 2026
View reviewed changes
Comment thread docs_user/modules/con_openshift-preparation-for-block-storage-adoption.adoc Outdated
@Jenny-Anne @klgill
Update docs_user/modules/con_openshift-preparation-for-block-storage-…
19e1d00 
…adoption.adoc

Co-authored-by: Katie Gilligan <kgilliga@redhat.com>
klgill
klgill approved these changes Mar 6, 2026
View reviewed changes

@klgill klgill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Mar 6, 2026
jistr
jistr approved these changes Mar 9, 2026
View reviewed changes

@jistr jistr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Mar 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jistr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Mar 9, 2026
@jistr

jistr commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@tosky

tosky commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

The only question is: would the two commits be squashed together, or should they be manually combined before? Asking because the second commit has a kind of minimal commit message and the commit itself is really not needed

@openshift-merge-bot
openshift-merge-bot Bot merged commit 7be7de2 into openstack-k8s-operators:main Mar 9, 2026
6 checks passed
@klgill

klgill commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

/cherry-pick 18.0-fr5

@openshift-cherrypick-robot

openshift-cherrypick-robot commented Mar 9, 2026

Copy link
Copy Markdown

@klgill: new pull request created: #1298

Details

In response to this:

/cherry-pick 18.0-fr5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tosky tosky tosky left review comments
@jistr jistr jistr approved these changes
@klgill klgill klgill approved these changes

Assignees

@jistr jistr

@klgill klgill

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Jenny-Anne @jistr @tosky @klgill @openshift-cherrypick-robot