fc-cinder-glance-with-cinder - #1287
Conversation
|
Hi @Jenny-Anne. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tosky
left a comment
tosky
left a comment
There was a problem hiding this comment.
Looks fine, just a comment inline
…adoption.adoc Co-authored-by: Katie Gilligan <kgilliga@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jistr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
The only question is: would the two commits be squashed together, or should they be manually combined before? Asking because the second commit has a kind of minimal commit message and the commit itself is really not needed |
7be7de2
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr5 |
|
@klgill: new pull request created: #1298 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
https://issues.redhat.com/browse/OSPRH-23008