Skip to content

mariadb_copy: replace sleep workarounds with persistent pod retry pattern - #1361

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
ciecierski:osprh-27386-mariadb-copy-persistent-pod
May 19, 2026
Merged

mariadb_copy: replace sleep workarounds with persistent pod retry pattern#1361
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
ciecierski:osprh-27386-mariadb-copy-persistent-pod

Conversation

@ciecierski

@ciecierski ciecierski commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the temporary mariadb_client_timeout sleep and wait bgp pause workarounds in mariadb_copy with a retry loop that polls the podified MariaDB via the already-running mariadb-copy-data pod, eliminating the race condition where commands were executed before the network was fully programmed (same approach used by get_services_configuration).
  • Align pre_checks.bash with the docs by replacing the ephemeral oc run mariadb-client --rm ... sleep && mysql pattern with oc rsh mariadb-copy-data, restoring docs-tests parity.
  • Add a corresponding "wait for podified MariaDB reachable" step to the docs procedure with a BGP/IPv6 NOTE.
  • Remove the mariadb_client_timeout variable from common_defaults as it has no remaining references.

Resolves: OSPRH-27386

Made with Cursor

@ciecierski
ciecierski force-pushed the osprh-27386-mariadb-copy-persistent-pod branch from 4755dc8 to 7982e13 Compare April 10, 2026 12:19
Comment thread tests/roles/mariadb_copy/tasks/main.yaml
@jistr

jistr commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@github-actions

github-actions Bot commented May 2, 2026

Copy link
Copy Markdown

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this PR will be closed in 7 days.

@github-actions github-actions Bot added the Stale label May 2, 2026
@jistr jistr removed the Stale label May 4, 2026
@ciecierski

Copy link
Copy Markdown
Contributor Author

Still busy testing this change in downstream

@klgill klgill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor edit and a question.

Comment thread docs_user/modules/proc_migrating-databases-to-mariadb-instances.adoc Outdated
…tern

Replace the temporary mariadb_client_timeout sleep and bgp wait pauses
with a proper retry loop that polls the podified MariaDB via the
already-running mariadb-copy-data pod, eliminating the race condition
where commands were executed before the network was fully programmed.
Also align pre_checks.bash with the docs by using oc rsh mariadb-copy-data
instead of the ephemeral mariadb-client pod, and add a corresponding
wait step to the docs procedure.

Resolves: OSPRH-27386
Made-with: Cursor
@ciecierski
ciecierski force-pushed the osprh-27386-mariadb-copy-persistent-pod branch from 7982e13 to 824d9ed Compare May 7, 2026 11:09
@openshift-ci openshift-ci Bot removed the lgtm label May 7, 2026
@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/356b524ec5034264abab479d9cd90fee

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph POST_FAILURE in 3h 10m 20s
adoption-standalone-to-crc-no-ceph POST_FAILURE in 3h 10m 31s
✔️ adoption-docs-preview SUCCESS in 1m 36s

@klgill klgill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ciecierski

Copy link
Copy Markdown
Contributor Author

recheck

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/2e882a9c354a47c8b172a9749a140dba

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph POST_FAILURE in 3h 09m 02s
adoption-standalone-to-crc-no-ceph POST_FAILURE in 3h 12m 04s
✔️ adoption-docs-preview SUCCESS in 1m 39s

@ciecierski

Copy link
Copy Markdown
Contributor Author

recheck

@ciecierski
ciecierski requested a review from jistr May 13, 2026 11:50

@jistr jistr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented May 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jistr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit a10ba73 into openstack-k8s-operators:main May 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants