Skip to content

Fix possible race condition in swift_migration check - #1362

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
cschwede:fix-cix-1318
Apr 15, 2026
Merged

Fix possible race condition in swift_migration check#1362
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
cschwede:fix-cix-1318

Conversation

@cschwede

@cschwede cschwede commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Updated rings were only pushed to the first controller node, resulting in a data movement loop: controller 1 pushed data to OpenShift and removed it locally, while controller 2 and 3 were detecting missing data
on controller 1 (because they were still using old rings) and replicating back to controller 1.

Update both the docs and the test role to distribute rings to all three controller nodes and restart Swift services on each.

Also add the -ignore_readdir_race option to the find command that checks for remaining .data/.db files on the standalone node. The replicator may remove empty directories while find is iterating, causing spurious errors.

JIRA: OSPCIX-1318

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fac7aa01feea42af93b72573e0fbe9bd

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph FAILURE in 2h 15m 10s
✔️ adoption-standalone-to-crc-no-ceph SUCCESS in 3h 05m 41s

@cschwede

Copy link
Copy Markdown
Contributor Author

recheck

Updated rings were only pushed to the first controller node, resulting
in a data movement loop: controller 1 pushed data to OpenShift and
removed it locally, while controller 2 and 3 were detecting missing data
on controller 1 (because they were still using old rings) and
replicating back to controller 1.

Update both the docs and the test role to distribute rings to all three
controller nodes and restart Swift services on each.

Also add the -ignore_readdir_race option to the find command that checks
for remaining .data/.db files on the standalone node. The replicator may
remove empty directories while find is iterating, causing spurious
errors.

JIRA: OSPCIX-1318

Signed-off-by: Christian Schwede <cschwede@redhat.com>
@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cd52ec4bdd7842f0aed9b2ac905fbc44

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph RETRY_LIMIT in 26m 33s
adoption-standalone-to-crc-no-ceph RETRY_LIMIT in 27m 51s
✔️ adoption-docs-preview SUCCESS in 1m 27s

@cschwede

Copy link
Copy Markdown
Contributor Author

recheck

@ciecierski

Copy link
Copy Markdown
Contributor

Multinode job test-project started here:
https://review.rdoproject.org/r/c/testproject/+/58791/3/.zuul.yaml

@cschwede

Copy link
Copy Markdown
Contributor Author

Multinode job test-project started here: https://review.rdoproject.org/r/c/testproject/+/58791/3/.zuul.yaml

Output looks much better, the drain check succeeded after 50 seconds.

@ciecierski
ciecierski requested a review from klgill April 15, 2026 07:22
@ciecierski
ciecierski requested review from holser and jistr April 15, 2026 07:22
@ciecierski

Copy link
Copy Markdown
Contributor

/lgtm

@jistr jistr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Apr 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jistr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit d3e6e17 into openstack-k8s-operators:main Apr 15, 2026
6 checks passed
@cschwede
cschwede deleted the fix-cix-1318 branch April 16, 2026 12:37
@ciecierski

Copy link
Copy Markdown
Contributor

/cherry-pick 18.0-fr5

@openshift-cherrypick-robot

Copy link
Copy Markdown

@ciecierski: new pull request created: #1402

Details

In response to this:

/cherry-pick 18.0-fr5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants