Skip to content

Use combined swift-conversion service for rolling node conversion - #1366

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
cschwede:swift-rolling-conversion
Apr 22, 2026
Merged

Use combined swift-conversion service for rolling node conversion#1366
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
cschwede:swift-rolling-conversion

Conversation

@cschwede

@cschwede cschwede commented Apr 17, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor

Combines the tripleo-cleanup and swift services in a single swift-conversion service. By using "serial: 1" Swift storage servers are stopped only on a single node at a time. This way there is no service interruption when using three replicas (default) - two storage nodes will be always available.

JIRA: OSPRH-28625

@cschwede
cschwede requested a review from klgill April 17, 2026 13:11
@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Apr 17, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4e31a570c3c74fe1962999eb86917c4f

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph FAILURE in 2h 07m 06s
✔️ adoption-standalone-to-crc-no-ceph SUCCESS in 3h 05m 38s
✔️ adoption-docs-preview SUCCESS in 1m 21s

@cschwede

cschwede commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@cschwede

cschwede commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@cschwede
cschwede requested review from fmount, fultonj and jistr April 20, 2026 12:24
klgill
klgill approved these changes Apr 20, 2026
View reviewed changes

@klgill klgill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Apr 20, 2026
fultonj
fultonj reviewed Apr 20, 2026
View reviewed changes

@fultonj fultonj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Letting others review before merging

fmount
fmount reviewed Apr 20, 2026
View reviewed changes

@fmount fmount left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of using a swift-conversion service. I have a couple of minor comments, lgtm otherwise!

Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc
@cschwede
Use combined swift-conversion service for rolling node conversion
bdd6b68 
Combines the tripleo-cleanup and swift services in a single
swift-conversion service. By using "serial: 1" Swift storage servers are
stopped only on a single node at a time. This way there is no service
interruption when using three replicas (default) - two storage nodes
will be always available.

JIRA: OSPRH-28625

Signed-off-by: Christian Schwede <cschwede@redhat.com>
@cschwede
cschwede force-pushed the swift-rolling-conversion branch from 0b2f16a to bdd6b68 Compare April 22, 2026 07:23
@openshift-ci openshift-ci Bot removed the lgtm label Apr 22, 2026
@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Apr 22, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/659fdf7bc2284b72a2fd89880516efa2

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph NODE_FAILURE Node request 100-0008215509 failed in 0s
❌ adoption-standalone-to-crc-no-ceph NODE_FAILURE Node request 100-0008215510 failed in 0s
✔️ adoption-docs-preview SUCCESS in 1m 38s

fmount
fmount approved these changes Apr 22, 2026
View reviewed changes

@fmount fmount left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Apr 22, 2026
@fmount

fmount commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

recheck

@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Apr 22, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dc85fc152f0742bc9abecc90ca15d5bc

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph NODE_FAILURE Node request 100-0008215512 failed in 0s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 1h 43m 33s
✔️ adoption-docs-preview SUCCESS in 1m 59s

@cschwede

cschwede commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@klgill

klgill commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

@cschwede Can you confirm whether this doc change is an async change, or is it dependent on a release?

jistr
jistr approved these changes Apr 22, 2026
View reviewed changes

@jistr jistr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Apr 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jistr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 8fdee71 into openstack-k8s-operators:main Apr 22, 2026
6 checks passed
@cschwede
cschwede deleted the swift-rolling-conversion branch April 22, 2026 15:22
@cschwede

cschwede commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

@cschwede Can you confirm whether this doc change is an async change, or is it dependent on a release?

Should be most likely in FR6, when this becomes available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fultonj fultonj fultonj left review comments
@jistr jistr jistr approved these changes
@fmount fmount fmount approved these changes
@klgill klgill klgill approved these changes

Assignees

@jistr jistr

@fultonj fultonj

@fmount fmount

@klgill klgill

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cschwede @fmount @klgill @jistr @fultonj