octavia-adoption: perform failover only on amphora LBs - #1372
Conversation
During our tests, tobiko creates an ovn load balancer in the source cloud. ovn load balancers don't support failovers so they need to be skipped in the "perform failover of existing load balancers" task. Update the docs accordingly.
|
This PR is stale because it has been for over 15 days with no activity. |
|
@gthiemonge Are you planing to land the change? It is marked stale and you have a suggestion from Katie after review to be addressed. |
Yeah, I'm still working on it, I'm testing it in the CI |
Ack, thank you for confirming |
| ---- | ||
| + | ||
| [NOTE] | ||
| OVN load balancers do not support failover because they do not need to be updated during upgrades. |
There was a problem hiding this comment.
I'm a bit confused by this sentence. During an upgrade, is it optional to update OVN load balancers? And what is the distinction between "update" and "upgrade" in this context?
There was a problem hiding this comment.
"updating" an OVN load balancer doesn't make sense, there's nothing to do by the admins.
In this case, there's no distinction between upgrade and update.
There was a problem hiding this comment.
I'll try to rephrase it
There was a problem hiding this comment.
what about "Failover is not applicable to OVN load balancers. As native components of the OVN infrastructure, they do not require actions during upgrades and updates."
There was a problem hiding this comment.
Just 1 minor rephrase, and this PR is good to go. I can approve after you commit the suggestion.
Co-authored-by: Katie Gilligan <kgilliga@redhat.com>
86068ad to
829bb25
Compare
|
New changes are detected. LGTM label has been removed. |
|
The PR was successfully tested in uni01alpha-adoption job |
|
Build failed (check pipeline). Post ✔️ noop SUCCESS in 0s |
|
recheck |
…d-balancers.adoc Co-authored-by: Katie Gilligan <kgilliga@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
5ead8e6
into
openstack-k8s-operators:main
4 participants
During our tests, tobiko creates an ovn load balancer in the source cloud.
ovn load balancers don't support failovers so they need to be skipped in the "perform failover of existing load balancers" task. Update the docs accordingly.