Skip to content

Use server-side apply for swift-ring-files ConfigMap - #1382

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:OSPRH-25258
May 19, 2026
Merged

Use server-side apply for swift-ring-files ConfigMap#1382
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:OSPRH-25258

Conversation

@fmount

@fmount fmount commented May 7, 2026

Copy link
Copy Markdown
Contributor

Client-side oc apply writes the entire manifest into the last-applied-configuration annotation, which can exceed the limit when Swift ring files are large. Using oc apply --server-side avoids this annotation entirely while remaining idempotent, unlike oc create which would fail on retries if the resource already exists.

Closes: OSPRH-25258

@fmount
fmount requested review from jistr and klgill May 7, 2026 20:04
@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/76912cd620ff405fa266ebef17529092

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph POST_FAILURE in 3h 07m 56s
adoption-standalone-to-crc-no-ceph POST_FAILURE in 3h 08m 37s
✔️ adoption-docs-preview SUCCESS in 1m 51s

@fmount

fmount commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/557072fd3f344aafbebe686e8c3566a6

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph POST_FAILURE in 3h 06m 15s
adoption-standalone-to-crc-no-ceph POST_FAILURE in 3h 08m 33s
✔️ adoption-docs-preview SUCCESS in 1m 36s

Comment thread docs_user/modules/proc_adopting-the-object-storage-service.adoc
Client-side `oc apply` writes the entire manifest into the
last-applied-configuration annotation, which can exceed the limit when Swift
ring files are large. Using `oc apply --server-side` avoids this annotation
entirely while remaining idempotent, unlike `oc create` which would fail on
retries if the resource already exists.

Closes: OSPRH-25258

Co-Authored-By: Claude Opus <noreply@anthropic.com>
Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount
fmount requested a review from klgill May 8, 2026 13:01

@klgill klgill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/eae9faa0743e4c018b814d3b0c719c82

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph POST_FAILURE in 3h 07m 40s
adoption-standalone-to-crc-no-ceph POST_FAILURE in 3h 12m 40s
✔️ adoption-docs-preview SUCCESS in 1m 39s

@fmount

fmount commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/36fd443138bd45569f0e5de5a04a1e71

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph POST_FAILURE in 3h 05m 47s
adoption-standalone-to-crc-no-ceph POST_FAILURE in 3h 08m 57s
✔️ adoption-docs-preview SUCCESS in 1m 41s

@fmount

fmount commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@fmount

fmount commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

@jistr are we ok merging this change?

@openshift-ci

openshift-ci Bot commented May 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jistr jistr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-merge-bot
openshift-merge-bot Bot merged commit 19a2827 into openstack-k8s-operators:main May 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants