Skip to content

Remove custom OVN ConfigMap/DataPlaneService workaround for DCN - #1395

Open
fultonj wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fultonj:OSPRH-30146-ansible
Open

Remove custom OVN ConfigMap/DataPlaneService workaround for DCN#1395
fultonj wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fultonj:OSPRH-30146-ansible

Conversation

@fultonj

@fultonj fultonj commented May 14, 2026

Copy link
Copy Markdown
Contributor

Remove the custom ovncontroller-config-dcn ConfigMap, ovn-dcn DataPlaneService, and DCN nodeset patching that was working around OVN SB connectivity for DCN compute nodes. The standard OVN service uses DNS (ovsdbserver-sb.openstack.svc) which resolves to internalapi IPs via DNSData CRs. With proper routes in the internalapi NAD, the standard mechanism should work without hardcoding tcp: entries, which also broke TLS scenarios.

The NAD route patching is retained as it is still required for macvlan pods to reach DCN subnets.

Tracker: OSPRH-30146

@openshift-ci

openshift-ci Bot commented May 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jistr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fultonj
fultonj requested a review from karelyatin May 14, 2026 18:02
@fultonj
fultonj marked this pull request as draft May 14, 2026 18:02
@fultonj

fultonj commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

This patch has not yet been tested so please do not merge.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this PR will be closed in 7 days.

@github-actions github-actions Bot added the Stale label May 30, 2026
@github-actions github-actions Bot closed this Jun 6, 2026
@fultonj

fultonj commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

@gais-ameer I can re-open this patch whenever you need me to. Just let me know. Thanks.

@fultonj fultonj reopened this Jul 21, 2026
Remove the custom ovncontroller-config-dcn ConfigMap, ovn-dcn
DataPlaneService, and DCN nodeset patching that was working around
OVN SB connectivity for DCN compute nodes. The standard OVN service
uses DNS (ovsdbserver-sb.openstack.svc) which resolves to internalapi
IPs via DNSData CRs. With proper routes in the internalapi NAD, the
standard mechanism should work without hardcoding tcp:<IP> entries,
which also broke TLS scenarios.

The NAD route patching is retained as it is still required for macvlan
pods to reach DCN subnets.

Tracker: OSPRH-30146

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: John Fulton <fulton@redhat.com>
@fultonj
fultonj force-pushed the OSPRH-30146-ansible branch from d5f3dcd to 50c5c56 Compare July 21, 2026 15:55
@fultonj fultonj changed the title [DO NOT MERGE] Remove custom OVN ConfigMap/DataPlaneService workaround for DCN Remove custom OVN ConfigMap/DataPlaneService workaround for DCN Jul 21, 2026
@fultonj
fultonj marked this pull request as ready for review July 21, 2026 15:57
@fultonj

fultonj commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

@gais-ameer tested DCN adoption with this patch and it succeeded.

Thus, I'm re-opening this PR to remove unnecessary tasks.

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/ce5e742f52c7405f821596ee1d9ee4e8

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 3h 14m 54s
adoption-standalone-to-crc-no-ceph NODE_FAILURE Node(set) request 100-0000149023 failed in 0s

@jistr jistr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fultonj

fultonj commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/279695ce3de14c1194934f8b6d87ca82

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 3h 19m 10s
adoption-standalone-to-crc-no-ceph NODE_FAILURE Node(set) request 100-0000151051 failed in 0s

@jistr

jistr commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants