Skip to content

Fix quota set to target admin project instead of default - #1438

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
abhibongale:fix_ironic-post-adoption-quota
Jul 28, 2026
Merged

Fix quota set to target admin project instead of default#1438
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
abhibongale:fix_ironic-post-adoption-quota

Conversation

@abhibongale

@abhibongale abhibongale commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

PR #1412 added a quota increase for pre-adoption Ironic test
instances, but targeted project 'default' instead of 'admin'.
The OS_CLOUD=overcloud authenticates as project admin
(clouds.yaml: project_name: admin), so quota set should
target admin to match the project instances are created under.

Since adoption migrates the TripleO DB, this quota carries
over to the adopted cloud, providing headroom for
post-adoption instance creation as well.

@jistr

jistr commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

I think this should be somehow reconciled with https://github.com/openstack-k8s-operators/data-plane-adoption/pull/1412/changes . If we merge this PR, we'll do the quota setting in two different places. cc @rebtoor

EDIT: sorry i now read the commit message and i see what's going on :). Still i think it would be good to get a review from @rebtoor :)

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/e48926ac9a76494596a8258f19652c9e

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph RETRY_LIMIT in 4m 31s
adoption-standalone-to-crc-no-ceph RETRY_LIMIT in 5m 03s

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/af805912c5bc44e39d60f37fbb6795ff

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 3h 22m 01s
adoption-standalone-to-crc-no-ceph NODE_FAILURE Node(set) request 100-0000141496 failed in 0s

@abhibongale
abhibongale force-pushed the fix_ironic-post-adoption-quota branch from 4b4dd56 to 3497806 Compare July 14, 2026 08:19
@abhibongale abhibongale changed the title Fix quota increase to target cloud Fix quota set to target admin project instead of default Jul 14, 2026
PR openstack-k8s-operators#1412 added a quota increase for pre-adoption Ironic test
instances, but targeted project 'default' instead of 'admin'.
The OS_CLOUD=overcloud authenticates as project admin
(clouds.yaml: project_name: admin), so quota set should
target admin to match the project instances are created under.

Since adoption migrates the TripleO DB, this quota carries
over to the adopted cloud, providing headroom for
post-adoption instance creation as well.

Related-Bug: openstack-k8s-operators#1412
Signed-off-by: Abhishek Bongale <abhishekbongale@outlook.com>
@abhibongale
abhibongale force-pushed the fix_ironic-post-adoption-quota branch from 3497806 to f49f9a2 Compare July 21, 2026 11:07
@centosinfra-prod-github-app

Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Unable to update github.com/openstack-k8s-operators/data-plane-adoption

@abhibongale

abhibongale commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/recheck

@jistr
jistr requested a review from rebtoor July 23, 2026 08:16

@rebtoor rebtoor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@rebtoor

rebtoor commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@abhibongale don't forget to remove the work in progress label please

@jistr jistr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jistr, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 89b86f9 into openstack-k8s-operators:main Jul 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants