Refactor docs workflow to use GitHub Pages Actions - #1458
Conversation
Replace force-pushing the gh-pages branch with a build job that uploads a Pages artifact and a deploy job that publishes via actions/deploy-pages.
jistr
left a comment
There was a problem hiding this comment.
/lgtm
Looks good, i wonder if we can run it somehow before merging, or we have to merge and see. Maybe in a fork it could be ran but i guess it involves setting up github pages and whatnot, maybe we can just merge and if anything breaks we can fix or as a last resort do a revert?
There is build artifact download URL: https://github.com/openstack-k8s-operators/data-plane-adoption/actions/runs/30264924952/artifacts/8652376895. It was generated by this pull request. What is not tested is a GitHub Pages deploy, which is using native Github workflow. For whatever failure I can revert it and try to post again |
|
Ack let's see :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jistr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ee60e75
into
openstack-k8s-operators:main
Replace force-pushing the gh-pages branch with a build job that uploads a Pages artifact and a deploy job that publishes via actions/deploy-pages.