Fix adoption order: adopt Cinder before Glance in test_with_ceph - #1461
Open
rebtoor wants to merge 1 commit into
Open
Fix adoption order: adopt Cinder before Glance in test_with_ceph#1461rebtoor wants to merge 1 commit into
rebtoor wants to merge 1 commit into
Conversation
When glance_backend is set to 'cinder' (overriding the default 'ceph'), the Glance operator waits for Cinder resources to be ready before starting Glance pods. In the current role ordering, glance_adoption runs before cinder_adoption, causing a deadlock: Glance waits for Cinder, but Cinder hasn't been adopted yet. Move cinder_adoption before glance_adoption to match the ordering already used in test_minimal.yaml. This is safe because Cinder depends only on Keystone and MariaDB (both already adopted at this point), while Glance may depend on Cinder when configured with the cinder backend. Related-Issue: #OSPRH-32880 Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
cinder_adoptionbeforeglance_adoptionintest_with_ceph.yamltoprevent a deadlock when
glance_backendis set tocinder.Problem
When
glance_backendis overridden from its defaultcephtocinder(e.g. in the uni05epsilon-adoption scenario), the Glance operator detects
that Cinder is required and waits for Cinder resources to become ready
before starting Glance pods. However, in the current role ordering,
glance_adoptionruns beforecinder_adoption, causing a deadlock:Glance waits for Cinder, but Cinder hasn't been adopted yet.
This manifests as Glance pods never starting, with the
OpenStackControlPlane CR showing:
Fix
Move
cinder_adoptionbeforeglance_adoption. This matches the orderingalready used in
test_minimal.yamland is safe because:glance_backend: cinder)Made with Cursor