Skip to content

Commit bfa90b7

Browse files
committed
Support per-scope sigstore remap targets
Depends-On: openstack-k8s-operators/openstack-operator#1972 Signed-off-by: rabi <ramishra@redhat.com>
1 parent 7643b58 commit bfa90b7

5 files changed

Lines changed: 14 additions & 13 deletions

File tree

roles/edpm_podman/defaults/main.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,4 +110,3 @@ edpm_container_signature_verification: false
110110
edpm_container_signature_cosign_key_data: ""
111111
edpm_container_signature_cosign_key_path: "/etc/pki/containers/cosign-redhat.pub"
112112
edpm_container_signature_registry_mappings: []
113-
edpm_container_signature_signed_prefix: ""

roles/edpm_podman/meta/argument_specs.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -192,12 +192,7 @@ argument_specs:
192192
List of source-to-mirror registry mappings for signature
193193
verification. Each entry is a dict with 'source' (original
194194
registry prefix, used as policy.json key) and 'mirror' (mirror
195-
registry, used for sigstore attachment lookups). Auto-populated
196-
by the openstack-operator from IDMS/ICSP and ClusterImagePolicy.
197-
edpm_container_signature_signed_prefix:
198-
type: str
199-
default: ""
200-
description: >
201-
Optional original registry prefix where images were signed. When set,
202-
edpm_podman writes a remapIdentity signedIdentity policy to map mirror
203-
registry references back to the original signing identity.
195+
registry, used for sigstore attachment lookups). Entries may
196+
also include 'signedPrefix' for per-mapping remapIdentity
197+
configuration. Auto-populated by the openstack-operator from
198+
IDMS/ICSP and ClusterImagePolicy.

roles/edpm_podman/molecule/install/converge.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
edpm_container_signature_registry_mappings:
3232
- source: "registry.redhat.io/rhoso"
3333
mirror: "mirror.example.com:5000/rhoso"
34+
signedPrefix: "registry.redhat.io/rhoso"
3435
edpm_container_signature_cosign_key_data: "{{ test_cosign_key_data }}"
3536

3637
- name: Test podman network ls
@@ -49,7 +50,9 @@
4950
that:
5051
- policy.transports.docker["registry.redhat.io/rhoso"][0].type == "sigstoreSigned"
5152
- policy.transports.docker["registry.redhat.io/rhoso"][0].keyPath == "/etc/pki/containers/cosign-redhat.pub"
52-
- "'signedIdentity' not in policy.transports.docker['registry.redhat.io/rhoso'][0]"
53+
- policy.transports.docker["registry.redhat.io/rhoso"][0].signedIdentity.type == "remapIdentity"
54+
- policy.transports.docker["registry.redhat.io/rhoso"][0].signedIdentity.prefix == "registry.redhat.io/rhoso"
55+
- policy.transports.docker["registry.redhat.io/rhoso"][0].signedIdentity.signedPrefix == "registry.redhat.io/rhoso"
5356
- policy.transports.docker["registry.redhat.io"][0].type == "signedBy"
5457
- policy.transports.docker["registry.access.redhat.com"][0].type == "signedBy"
5558
vars:

roles/edpm_podman/tasks/install.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,13 +204,13 @@
204204
'type': 'sigstoreSigned',
205205
'keyPath': edpm_container_signature_cosign_key_path
206206
} | combine(
207-
(edpm_container_signature_signed_prefix | length > 0)
207+
((item.signedPrefix | default('')) | length > 0)
208208
| ternary(
209209
{
210210
'signedIdentity': {
211211
'type': 'remapIdentity',
212212
'prefix': item.source,
213-
'signedPrefix': edpm_container_signature_signed_prefix
213+
'signedPrefix': item.signedPrefix
214214
}
215215
},
216216
{}

zuul.d/projects.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
- podified-multinode-edpm-baremetal-bootc-pipeline
77
github-check:
88
jobs:
9+
# Keep the bootc container image explicit when the templated job resolves from ci-framework main.
10+
- cifmw-crc-podified-edpm-baremetal-bootc:
11+
vars:
12+
cifmw_update_containers_edpm_image_url: quay.io/openstack-k8s-operators/edpm-bootc:latest-qcow2
913
- noop
1014
- edpm-ansible-tempest-multinode
1115
- edpm-ansible-baremetal-minor-update

0 commit comments

Comments
 (0)