Make edpm-ansible ansible 2.19 compatible#993
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fe73e368b5d14fbd8cf6dcab8d4b24c6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 48s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/19b4cc75660b49ba8edf6cf3e858d9ad ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 02m 23s |
|
recheck |
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/openstack-operator#1547 is needed. |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/01484197dc524220a01b6b17a87715dd ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 26s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/876de4103a4146669d915a6c7b7cb754 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 18m 30s |
SeanMooney
left a comment
SeanMooney
left a comment
There was a problem hiding this comment.
the hugpage change looks corect but please update the PR title to refect what your actully dooing
which is refactoring the playbooks for ansible 2.19.0 compatiablity
| _nonconfig_hugepages: {} | ||
| _hugepages_modification: false | ||
| when: edpm_kernel_hugepages | length | ||
| when: edpm_kernel_hugepages | default({}) | length > 0 |
There was a problem hiding this comment.
OK this is the actual change to the huge page
the other 3 commits in this pr are unrealted to the subject of the PR.
There was a problem hiding this comment.
All commits are related to the jira linked. I'll update the PR when everything is fixed for the jira.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7e8222a276dc4f168d55bd21538c963a ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 18m 37s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/70a93755a71d49a1965e0589002106f2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 23s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6395c52d8ccf450b919c3ce0ae903b98 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 26s |
rabi
force-pushed
the
conditional
branch
2 times, most recently
from
2e9245d to
c2cd284
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9df6f451cc014792882a7d0ae08e4584 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 40m 44s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7b49d8272b054436a2423bbfd70f7ffa ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 37m 59s |
rabi
force-pushed
the
conditional
branch
2 times, most recently
from
0a92bb5 to
c3d6c3c
Compare
rabi
changed the title
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d1c35f9c7fd349968ef736a6eff443cd ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 56m 00s |
Non boolean conditionals are not allowed in ansible 2.19. Fix private var access from namespace not allowed Depends-On: openstack-k8s-operators/openstack-operator#1547 Depends-On: openstack-k8s-operators/ci-framework#3168 Signed-off-by: rabi <ramishra@redhat.com>
This reverts commit 4d7155e. Signed-off-by: rabi <ramishra@redhat.com>
rabi
force-pushed
the
conditional
branch
3 times, most recently
from
48dfe3a to
674a0c1
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d35001c2b964455da1bef976c411c261 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 47m 16s |
| when: | ||
| - not edpm_enable_chassis_extport | bool | ||
| - cleanup_ovn_cms_options.rc == 0 | ||
| - cleanup_ovn_cms_options_stdout is defined |
There was a problem hiding this comment.
Are these lines needed? It should always be defined when "cleanup_ovn_cms_options.rc == 0" shouldn't it?
There was a problem hiding this comment.
yeah it's kind of redundant but does not hurt, better would have been to check for empty string.
| ("'ssh_host_key_ecdsa_public' not in ansible_facts") | ||
| - ('ssh_host_key_rsa_public' not in ansible_facts) or | ||
| ('ssh_host_key_ed25519_public' not in ansible_facts) or | ||
| ('ssh_host_key_ecdsa_public' not in ansible_facts) |
There was a problem hiding this comment.
Is this fixing a separate bug?
There was a problem hiding this comment.
No, this is broken conditional in 2.19.
Conditional result was "'ssh_host_key_rsa_public' not in [...]" of type 'str', which evaluates to True. Conditionals must have a boolean result.
Broken conditionals can be temporarily allowed with the ALLOW_BROKEN_CONDITIONALS configuration option.
Signed-off-by: rabi <ramishra@redhat.com>
With ansible 2.19 jinja templating changes, data that can contain templates will require explicit trust via trust_as_template to be allowed to render. Signed-off-by: rabi <ramishra@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rabi, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit f1e09b5
into
openstack-k8s-operators:main
|
Hmm.. we need to merge the dependan-on PRs as well, else the CI would be broken I think. |
3 participants
Ports edpm-ansible to ansible 2.19
Depends-On: openstack-k8s-operators/openstack-operator#1547
Depends-On: openstack-k8s-operators/ci-framework#3168
Depends-On: openstack-k8s-operators/data-plane-adoption#1023
jira: https://issues.redhat.com/browse/OSPRH-18609