Add extraMounts interface

[rabi]

We can inject policy files, heat plugins etc using this.

Jira: https://issues.redhat.com/browse/OSPRH-16695

[rabi]

/retest

[rabi]

/test functional

[olliewalsh]

Also should inherit the top-level mounts, similar to openstack-k8s-operators/openstack-operator#1441

[rabi]

Also should inherit the top-level mounts, similar to openstack-k8s-operators/openstack-operator#1441

You mean making additional change in openstack-operator right?

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d035843139fe4d7188fba0ee324b13b3

✔️ openstack-k8s-operators-content-provider SUCCESS in 31m 46s
❌ heat-operator-tempest-multinode RETRY_LIMIT in 10m 13s

[rabi]

/retest

[rabi]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6c6ecd8c0fa1465dac2df8354a445a86

✔️ openstack-k8s-operators-content-provider SUCCESS in 50m 38s
❌ heat-operator-tempest-multinode FAILURE in 34m 08s

[rabi]

/test heat-operator-build-deploy-kuttl

[rabi]

recheck

[fmount]

The patch itself look good to me. I'm wondering if we might want to add an envTest to validate the new spec parameter like we did in [1] (the same test is present in the other operators implementing extraMounts).

We can do in a follow up, but let me know if you want to have an additional commit here before we land this patch.

[1] https://github.com/openstack-k8s-operators/manila-operator/blob/main/test/functional/manila_controller_test.go#L1115

[rabi]

We can do in a follow up, but let me know if you want to have an additional commit here before we land this patch

Looks like heat-operator envTest coverage is limited and I don't see anything from deployments checked in any of the tests. It would require some work to assert that volume and mounts are propagated for heat-engine and api deployments. I'll add tests in a followup as this has passed CI and ready to be merged.

[fmount]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rabi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment